Skip to content

Remove icons from Geometry class sub-categories #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alfarok merged 6 commits into from
Dec 8, 2017
Merged

Remove icons from Geometry class sub-categories #8369

alfarok merged 6 commits into from
Dec 8, 2017

Conversation

@alfarok
Copy link
Contributor

@alfarok alfarok commented Nov 30, 2017 •
edited
Loading

Purpose

QNTM-2675

Supplemental Librarie PR

The purpose of this PR is to remove the icons from the Geometry class sub-categories. The icons beside the Geometry categories is confusing as they look like nodes and not sub-categories.

This PR simply includes the updated Librarie.min.js file. The modifications take place in this Librarie PR where any Element Type categorized as none does not load an icon. This is the same logic group types follow.

Documentation

Updated Wiki

For more info on Element Types see the Librarie Docs

image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner

FYIs

@Racel

@alfarok alfarok added the WIP label Nov 30, 2017
@mjkkirschner
Copy link
Member

mjkkirschner commented Nov 30, 2017

@alfarok - instead of altering the items in the layout spec - I think it makes sense to approach this generally - would we ever want categories like this to have icons? @Racel - can you look into simply not generating an image element on categories like this?

@Racel
Copy link
Contributor

Racel commented Nov 30, 2017

I agree with @mjkkirschner. We need a more general solution. Nested categories should never have an icon.

@alfarok
Copy link
Contributor Author

alfarok commented Nov 30, 2017

@mjkkirschner @Racel okay, no problem. The task description and AC discussed removing them or making them visually distinct for clarity so I wasn't sure if we wanted to completely remove all referenced code or if it's something that was going to be revisited down the line.

@alfarok alfarok mentioned this pull request Dec 4, 2017
Merged
7 tasks
@alfarok alfarok changed the title [WIP] Remove icons from Geometry class sub-categories Remove icons from Geometry class sub-categories Dec 5, 2017
@alfarok alfarok added PTAL Please Take A Look 👀 and removed WIP labels Dec 7, 2017
@mjkkirschner
Copy link
Member

mjkkirschner commented Dec 8, 2017

Can this be merged ?

@alfarok
Copy link
Contributor Author

alfarok commented Dec 8, 2017

@mjkkirschner yes will merge now along with this librarie PR

@alfarok alfarok merged commit f351c56 into DynamoDS:master Dec 8, 2017
@alfarok alfarok removed the PTAL Please Take A Look 👀 label Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alfarok @mjkkirschner @Racel