Skip to content

Update grpc and genproto library to avoid panic in ttrpc#1000

Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom
katiewasnothere:fix_ttrpc_status_panic
Apr 13, 2021
Merged

Update grpc and genproto library to avoid panic in ttrpc#1000
katiewasnothere merged 1 commit intomicrosoft:masterfrom
katiewasnothere:fix_ttrpc_status_panic

Conversation

@katiewasnothere
Copy link

This PR addresses the issue described in containerd/ttrpc#62 by following the same package versions used in upstream containerd (introduced here).

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@katiewasnothere katiewasnothere requested a review from a team as a code owner April 13, 2021 19:49
@katiewasnothere
Copy link
Author

@dcantah

@katiewasnothere katiewasnothere merged commit 840644c into microsoft:master Apr 13, 2021
@katiewasnothere katiewasnothere deleted the fix_ttrpc_status_panic branch April 13, 2021 19:52
TBBle added a commit to TBBle/hcsshim that referenced this pull request Sep 26, 2021
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
@TBBle TBBle mentioned this pull request Sep 26, 2021
2 tasks
TBBle added a commit to TBBle/hcsshim that referenced this pull request Nov 27, 2021
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle added a commit to TBBle/hcsshim that referenced this pull request May 4, 2022
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle added a commit to TBBle/hcsshim that referenced this pull request May 4, 2022
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants