test: go.mod: github/containerd/containerd v1.5.0-beta.4#968
Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom Mar 17, 2021
Merged
test: go.mod: github/containerd/containerd v1.5.0-beta.4#968katiewasnothere merged 1 commit intomicrosoft:masterfrom
katiewasnothere merged 1 commit intomicrosoft:masterfrom
Conversation
katiewasnothere
approved these changes
Mar 17, 2021
katiewasnothere
left a comment
There was a problem hiding this comment.
LGTM, could you update this branch as well?
dcantah
approved these changes
Mar 17, 2021
Contributor
Author
|
Thanks for review; containerd v1.5.0-beta.4 was also released since I opened this PR; I'll rebase and update to that version as well (assuming that's ok with you); I'll ping when I've updated |
0a6a367 to
0da34e8
Compare
Contributor
Author
|
rebased, and updated to v1.5.0-beta.4; ptal 👍 |
katiewasnothere
approved these changes
Mar 17, 2021
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
8603fdd to
e3bde0e
Compare
Contributor
Author
no worries, I was anticipating that (we tried using that option in the moby/moby repository, but it was too difficult to work with in an active repository 😞, so we disabled it again) rebased 👍 |
|
Yeah we may need to revisit enabling that option haha just waiting for the CI to finish and then I'll merge |
Contributor
Author
|
Thanks! |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.