Fix golangci linter issues#976
Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom Mar 18, 2021
Merged
Conversation
* Remove unused mutex for the grpc service in ncproxy * Remove unneccessary os.Stat call that didn't even check the return value *facepalm* Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Contributor
Author
|
This is one of a few PRs to get golangci happy with our repo before we swap over. #975 |
kevpar
reviewed
Mar 17, 2021
| if os.Stat(diffVhdPath); err == nil { | ||
| os.RemoveAll(diffVhdPath) | ||
| } | ||
| os.RemoveAll(diffVhdPath) |
Member
There was a problem hiding this comment.
Instead of removing the Stat call, should we be checking the return value?
Contributor
Author
There was a problem hiding this comment.
I didn't really even see a need for the stat call. If the file doesn't exist RemoveAll will just silently succeed anyways.
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facepalm
Signed-off-by: Daniel Canter dcanter@microsoft.com