Support passing in propagation flags on scsi mounts for LCOW#987
Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom Apr 13, 2021
Merged
Conversation
c593d6b to
a7fcef3
Compare
dcantah
approved these changes
Mar 29, 2021
Contributor
dcantah
left a comment
There was a problem hiding this comment.
Maybe revendor into /test and fix up the functional tests in a separate commit but this LGTM!
kevpar
reviewed
Mar 29, 2021
a7fcef3 to
6aacfd2
Compare
Author
|
@kevpar Could you take another look? |
dcantah
approved these changes
Apr 12, 2021
6aacfd2 to
c323550
Compare
kevpar
reviewed
Apr 13, 2021
internal/uvm/scsi.go
Outdated
| // `vmAccess` indicates what access to grant the vm for the hostpath | ||
| func (uvm *UtilityVM) AddSCSI(ctx context.Context, hostPath string, uvmPath string, readOnly bool, vmAccess VMAccessType) (*SCSIMount, error) { | ||
| return uvm.addSCSIActual(ctx, hostPath, uvmPath, "VirtualDisk", readOnly, vmAccess) | ||
| func (uvm *UtilityVM) AddSCSI(ctx context.Context, hostPath string, uvmPath string, readOnly bool, options []string, vmAccess VMAccessType) (*SCSIMount, error) { |
Member
There was a problem hiding this comment.
I think it will be clearer if we call this guestOptions instead of options.
Author
There was a problem hiding this comment.
I changed all instances in the scsi file. Does that work?
c323550 to
6b3229a
Compare
6b3229a to
d0ff4d1
Compare
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
d0ff4d1 to
d5f4aee
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See microsoft/opengcs#398 for details.
This PR updates the fields for scsi disk attachment to match those in the PR mentioned above and adds a test for the expected behavior of
rsharedmount propagation for scsi disks.Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com