This repository was archived by the owner on Jul 28, 2021. It is now read-only.
Support passing through arbitrary options and propagation flags for scsi mounts#398
Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom Apr 8, 2021
Conversation
dcantah
reviewed
Mar 29, 2021
05a5d0b to
c05ab78
Compare
dcantah
reviewed
Apr 8, 2021
dcantah
reviewed
Apr 8, 2021
dcantah
previously approved these changes
Apr 8, 2021
Contributor
dcantah
left a comment
There was a problem hiding this comment.
re-lgtm. Comments just on type casts that could be skipped
…csi mounts Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
c05ab78 to
01a2767
Compare
dcantah
approved these changes
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the mount propagation behavior for scsi mounts. The expected behavior is that a
rsharedmount propagates mountpoint events from container to host and vice versa. However, since we previously did not create the initial mountpoint for the device in the UVM with the correct propagation flags, events would not flow from the container back to the UVM as expected. This PR fixes this by supporting the ability to pass in arbitrary mount options when attaching a scsi disk.Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com