Skip to content

Switch CI to GitHub Actions#970

Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom
slonopotamus:gh-actions
Mar 17, 2021
Merged

Switch CI to GitHub Actions#970
katiewasnothere merged 1 commit intomicrosoft:masterfrom
slonopotamus:gh-actions

Conversation

@slonopotamus
Copy link
Contributor

@slonopotamus slonopotamus commented Mar 13, 2021

You can see example build run in my fork.

Note that current repo settings require AppVeyor build to pass for PR. This setting will need to be changed if you decide to merge.

@slonopotamus slonopotamus requested a review from a team as a code owner March 13, 2021 11:30
@ghost
Copy link

ghost commented Mar 13, 2021

CLA assistant check
All CLA requirements met.

TBBle added a commit to TBBle/hcsshim that referenced this pull request Mar 14, 2021
This gives a comparison-point for RS5, as used by AppVeyor, compared to
my 20H2 desktop machine.

TODO: Actually integrate a proper test-suite run, possibly using GitHub
Actions, per microsoft#936 and microsoft#970.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle added a commit to TBBle/hcsshim that referenced this pull request Mar 14, 2021
This gives a comparison-point for RS5, as used by AppVeyor, compared to
my 20H2 desktop machine.

TODO: Actually integrate a proper test-suite run, possibly using GitHub
Actions, per microsoft#936 and microsoft#970.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
@katiewasnothere
Copy link

Another thanks for working on this! This has been on our todo list for a while.

@dcantah
Copy link
Contributor

dcantah commented Mar 16, 2021

+2 on the thanks for this. Much appreciated ❤️

@slonopotamus slonopotamus force-pushed the gh-actions branch 3 times, most recently from 171962e to 0f6cb6c Compare March 17, 2021 07:28
Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
@slonopotamus
Copy link
Contributor Author

Updated PR, see new build run.

Copy link
Contributor

@anmaxvl anmaxvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let others take a second look.

Copy link

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@katiewasnothere katiewasnothere merged commit ac95fba into microsoft:master Mar 17, 2021
@slonopotamus slonopotamus deleted the gh-actions branch March 17, 2021 18:26
slonopotamus added a commit to slonopotamus/hcsshim that referenced this pull request Mar 17, 2021
This is a follow-up to microsoft#970
slonopotamus added a commit to slonopotamus/hcsshim that referenced this pull request Mar 17, 2021
This is a follow-up to microsoft#970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants