Add a utility function to exec in shimdiag for cri-containerd tests#992
Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom Apr 8, 2021
Merged
Conversation
1576885 to
554c3b9
Compare
dcantah
reviewed
Apr 8, 2021
dcantah
reviewed
Apr 8, 2021
anmaxvl
reviewed
Apr 8, 2021
554c3b9 to
623a520
Compare
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
623a520 to
8a22e26
Compare
dcantah
approved these changes
Apr 8, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…_utility Add a utility function to exec in shimdiag for cri-containerd tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new utility function in the cri-containerd test suite for running shimdiag exec commands. This PR will eventually be used by #931 to verify resources are updated as expected.
This PR additionally refactors some code related to pipe creation to prevent code duplication for running shimdiag exec requests from the test suite.
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com