Update google.golang.org/grpc and github.com/golang/protobuf#5613
Update google.golang.org/grpc and github.com/golang/protobuf#5613dims merged 3 commits intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
v1.38.0 is used by Kubernetes since kubernetes/kubernetes#100488. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
google.golang.org/grpc doesn't work with protobuf v1.3.5. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
Build succeeded.
|
1 similar comment
|
Build succeeded.
|
|
Build succeeded.
|
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
Build succeeded.
|
|
Hi, I'm curious about this change. Does it mean containerd is now no longer affected by containerd/ttrpc#62 ? |
|
This PR forgot to sync go.mod in integration/client/go.mod, so the new protobuf is not tested during intergation test. I try to run the integration in my repo zhsj@0fa92b5 and it seems the test fails. However the log doesn't give any useful message, so I'm not sure if it's related to protobuf updates. (Probably currently there's issue with GH infra, since containerd master also fails without useful logs) |
|
Also curious if this won't have side effects; I should probably dust off #5208 |
I believe these replace directives (github.com/gogo/googleapis and google.golang.org/genproto) are the workaround we have for the issue. Let me confirm. Lines 76 to 80 in c07711c |
|
The I'm mostly concerned about making sure we remain backward compatible with (older) clients; I'm not very familiar with the issues, but I know there were some hairy situations, and want to be sure existing clients don't break in unexpected ways when using the containerd API (otherwise it would require a major version update of the containerd API). |
|
We embed containerd and kubernetes together in a single binary in k3s, and we're running into containerd/ttrpc#62 after updating Kubernetes to 1.22, as it requires grpc v1.32.0 or newer. It seems like someone needs to bite the bullet on updating ttrpc to modern grpc? |
This was originally locked in microsoft#1000 based on containerd's resolution for containerd/ttrpc#62. However, this was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us. See also containerd/ttrpc#89, which documents that only google.golang.org/genproto needs to be locked. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
This was originally locked in microsoft#1000 based on containerd's resolution for containerd/ttrpc#62. However, this was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us. See also containerd/ttrpc#89, which documents that only google.golang.org/genproto needs to be locked. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
This was originally locked in microsoft#1000 based on containerd's resolution for containerd/ttrpc#62. However, this was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us. See also containerd/ttrpc#89, which documents that only google.golang.org/genproto needs to be locked. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
This was originally locked in microsoft#1000 based on containerd's resolution for containerd/ttrpc#62. However, this was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us. See also containerd/ttrpc#89, which documents that only google.golang.org/genproto needs to be locked. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
google.golang.org/grpc v1.38.0 is used by Kubernetes since
kubernetes/kubernetes#100488.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com