Skip to content

Upgrade google.golang.org/grpc from v1.27.1 to v1.38.0#89

Closed
kzys wants to merge 1 commit intocontainerd:mainfrom
kzys:upgrade-grpc
Closed

Upgrade google.golang.org/grpc from v1.27.1 to v1.38.0#89
kzys wants to merge 1 commit intocontainerd:mainfrom
kzys:upgrade-grpc

Conversation

@kzys
Copy link
Member

@kzys kzys commented Aug 20, 2021

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

@codecov-commenter
Copy link

Codecov Report

Merging #89 (b517f68) into main (360e86c) will increase coverage by 1.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   70.75%   72.74%   +1.98%     
==========================================
  Files          11       11              
  Lines         612      708      +96     
==========================================
+ Hits          433      515      +82     
- Misses        142      156      +14     
  Partials       37       37              
Impacted Files Coverage Δ
server.go 74.35% <0.00%> (-0.13%) ⬇️
handshake.go 100.00% <0.00%> (ø)
interceptor.go 100.00% <0.00%> (ø)
client.go 82.87% <0.00%> (+1.34%) ⬆️
metadata.go 93.02% <0.00%> (+2.39%) ⬆️
channel.go 84.31% <0.00%> (+2.49%) ⬆️
config.go 33.33% <0.00%> (+3.33%) ⬆️
unixcreds_linux.go 53.84% <0.00%> (+3.84%) ⬆️
services.go 47.36% <0.00%> (+5.57%) ⬆️
codec.go 66.66% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360e86c...b517f68. Read the comment docs.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
TBBle added a commit to TBBle/hcsshim that referenced this pull request Sep 26, 2021
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
@kzys
Copy link
Member Author

kzys commented Oct 26, 2021

Closing. #92 would be our new long-term approach.

@kzys kzys closed this Oct 26, 2021
TBBle added a commit to TBBle/hcsshim that referenced this pull request Nov 27, 2021
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle added a commit to TBBle/hcsshim that referenced this pull request May 4, 2022
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle added a commit to TBBle/hcsshim that referenced this pull request May 4, 2022
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants