Skip to content

[Merged by Bors] - feat: port CategoryTheory.Bicategory.Free#2482

Closed
mo271 wants to merge 482 commits intomasterfrom
port/CategoryTheory.Bicategory.Free
Closed

[Merged by Bors] - feat: port CategoryTheory.Bicategory.Free#2482
mo271 wants to merge 482 commits intomasterfrom
port/CategoryTheory.Bicategory.Free

Conversation

@mo271
Copy link
Copy Markdown
Collaborator

@mo271 mo271 commented Feb 24, 2023

@mo271 mo271 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Feb 24, 2023
@kim-em kim-em added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Feb 24, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Feb 27, 2023

This PR/issue depends on:

@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 27, 2023
@Ruben-VandeVelde Ruben-VandeVelde force-pushed the port/CategoryTheory.Bicategory.Free branch from 51a8ed2 to 3627f2a Compare April 11, 2023 11:46
@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 12, 2023
@Ruben-VandeVelde Ruben-VandeVelde force-pushed the port/CategoryTheory.Bicategory.Free branch from 7cc6880 to 4960355 Compare April 14, 2023 14:16
@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 14, 2023
YaelDillies and others added 17 commits May 10, 2023 16:09
Match leanprover-community/mathlib3#8289





Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
* Add `isSuffixOf`, `isSuffixOf?`, and `getRest` functions.
* Add `#align` statements.
* Indent function bodies.
Matches leanprover-community/mathlib3#18517

This result is required in #2508.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
See discussion at https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/mathport.20drops.20priorities.20in.20.60attribute.20.5Binstance.5D.60. `mathport` has been dropping the priorities on instances when using the `attribute` command.

This PR adds back all the priorities, except for `local attribute`, and instances involving coercions, which I didn't want to mess with.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Komyyy and others added 9 commits May 10, 2023 16:09
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: MonadMaverick <MonadMaverick@pm.me>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: MonadMaverick <MonadMaverick@pm.me>
Add some `pp_extended_field_notation`, for opt-in cases with additional arguments.



Co-authored-by: Kyle Miller <kmill31415@gmail.com>
@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 10, 2023
@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 13, 2023
@mattrobball mattrobball added awaiting-review and removed help-wanted The author needs attention to resolve issues labels May 18, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented May 18, 2023

Amazing, thanks @mattrobball, you'll have to explain to me sometime what was going on there!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 18, 2023
bors bot pushed a commit that referenced this pull request May 18, 2023
- [x] depends on: #2301 


Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Pol_tta <pol_tta@outlook.jp>
Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott@tqft.net>
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: Christopher Hoskin <christopher.hoskin@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: MonadMaverick <MonadMaverick@pm.me>
Co-authored-by: David Renshaw <dwrenshaw@gmail.com>
Co-authored-by: Matthew Robert Ballard <matt@mrb.email>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Pol_tta <MonadMaverick@pm.me>
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented May 18, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Bicategory.Free [Merged by Bors] - feat: port CategoryTheory.Bicategory.Free May 18, 2023
@bors bors bot closed this May 18, 2023
@bors bors bot deleted the port/CategoryTheory.Bicategory.Free branch May 18, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.