[Merged by Bors] - chore: port missing instance priorities#3613
Closed
[Merged by Bors] - chore: port missing instance priorities#3613
Conversation
Member
|
Was this done by looking through leanprover-community/mathlib3port@ff662d5? |
eric-wieser
reviewed
Apr 24, 2023
Contributor
Author
This was done by grepping for |
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
See discussion at https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/mathport.20drops.20priorities.20in.20.60attribute.20.5Binstance.5D.60. `mathport` has been dropping the priorities on instances when using the `attribute` command. This PR adds back all the priorities, except for `local attribute`, and instances involving coercions, which I didn't want to mess with. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
kim-em
added a commit
that referenced
this pull request
May 10, 2023
See discussion at https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/mathport.20drops.20priorities.20in.20.60attribute.20.5Binstance.5D.60. `mathport` has been dropping the priorities on instances when using the `attribute` command. This PR adds back all the priorities, except for `local attribute`, and instances involving coercions, which I didn't want to mess with. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
hrmacbeth
pushed a commit
that referenced
this pull request
May 10, 2023
See discussion at https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/mathport.20drops.20priorities.20in.20.60attribute.20.5Binstance.5D.60. `mathport` has been dropping the priorities on instances when using the `attribute` command. This PR adds back all the priorities, except for `local attribute`, and instances involving coercions, which I didn't want to mess with. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
hrmacbeth
pushed a commit
that referenced
this pull request
May 11, 2023
See discussion at https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/mathport.20drops.20priorities.20in.20.60attribute.20.5Binstance.5D.60. `mathport` has been dropping the priorities on instances when using the `attribute` command. This PR adds back all the priorities, except for `local attribute`, and instances involving coercions, which I didn't want to mess with. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion at https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/mathport.20drops.20priorities.20in.20.60attribute.20.5Binstance.5D.60.
mathporthas been dropping the priorities on instances when using theattributecommand.This PR adds back all the priorities, except for
local attribute, and instances involving coercions, which I didn't want to mess with.