[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18856#3609
Closed
[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18856#3609
Conversation
eric-wieser
reviewed
Apr 23, 2023
Mathlib/Data/ZMod/Basic.lean
Outdated
|
|
||
| ! This file was ported from Lean 3 source module data.zmod.basic | ||
| ! leanprover-community/mathlib commit 47a1a73351de8dd6c8d3d32b569c8e434b03ca47 | ||
| ! leanprover-community/mathlib commit 473ee9e095b89a24df125a4d363bd996f0989748 |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I just did this manually using the SHAs, should I have just let mathport build & etc? Thought it wouldn't be that bad as a one-line change
Member
There was a problem hiding this comment.
No, this one was fine to do manually; the dashboard should pick up the mathlib3 commit info in the next 15 minutes. There's certainly no need to wait for mathport for this PR.
eric-wieser
reviewed
Apr 23, 2023
Contributor
|
@ericrbg, you've written "DO NOT MERGE YET", yet it is marked for review. I'll leave it as |
Contributor
Author
|
I was waiting for the SHA from the second alphabetising PR - all good! thanks scott :) |
|
Pull request successfully merged into master. Build succeeded: |
kim-em
pushed a commit
that referenced
this pull request
May 10, 2023
hrmacbeth
pushed a commit
that referenced
this pull request
May 10, 2023
hrmacbeth
pushed a commit
that referenced
this pull request
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-ports leanprover-community/mathlib3#18856 and leanprover-community/mathlib3#18858
leanprover-community/mathlib3#18856 & leanprover-community/mathlib3#18858 for reviewer reference