This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(zmod/basic): remove unneeded import#18856
Closed
[Merged by Bors] - chore(zmod/basic): remove unneeded import#18856
Conversation
eric-wieser
approved these changes
Apr 23, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
Yes, this is extremely trivial to forward-port so I'm happy to merge it.
The out-of-sync-length rule is hard to apply right now as the dashboard is stale due to a dead server
bors merge
bors bot
pushed a commit
that referenced
this pull request
Apr 23, 2023
This file was importing a weird dependency; I am now minimising this.
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
This wasn't noticed in #18856
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 24, 2023
kim-em
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2023
hrmacbeth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2023
hrmacbeth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file was importing a weird dependency; I am now minimising this.
Will this sort of change be easy to forward-port? If not, I guess this can wait.