[Merged by Bors] - feat: port LinearAlgebra.Matrix.Circulant#3465
Closed
[Merged by Bors] - feat: port LinearAlgebra.Matrix.Circulant#3465
Conversation
Contributor
ymonbru
commented
Apr 16, 2023
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Contributor
Author
|
Most of the errors are from the tactic "decide", i don't know how to manage this In " Fin.circulant_isSymm_iff", the type is not accepted, i tryed to remove the "fun v => " from the proof and then lean tels that the terminasion of the term is not proven It's not a mistake but in "circulant_mul_comm" there was a case disjunction that i deleted while solving an error (i am not shure if it's a good thing or not) |
Contributor
|
Thanks! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com> Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
|
Pull request successfully merged into master. Build succeeded: |
kim-em
pushed a commit
that referenced
this pull request
May 10, 2023
Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com> Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
hrmacbeth
pushed a commit
that referenced
this pull request
May 10, 2023
Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com> Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
hrmacbeth
pushed a commit
that referenced
this pull request
May 11, 2023
Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com> Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.