[Merged by Bors] - feat: Order on the localization#3567
Closed
YaelDillies wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - feat: Order on the localization#3567YaelDillies wants to merge 6 commits intomasterfrom
YaelDillies wants to merge 6 commits intomasterfrom
Conversation
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 [`group_theory.monoid_localization`@`1f0096e6caa61e9c849ec2adbd227e960e9dff58`..`13b8e258f14bffb5def542aa78b803b0b80541aa`](https://leanprover-community.github.io/mathlib-port-status/file/group_theory/monoid_localization?range=1f0096e6caa61e9c849ec2adbd227e960e9dff58..13b8e258f14bffb5def542aa78b803b0b80541aa)
eric-wieser
reviewed
Apr 21, 2023
eric-wieser
reviewed
Apr 23, 2023
eric-wieser
reviewed
Apr 23, 2023
|
|
||
| @[to_additive] | ||
| theorem mk_left_injective (b : s) : Injective fun a => mk a b := fun c d h => by | ||
| have : Nonempty s := ⟨b⟩ -- porting note: Needed to add this `have` |
Member
There was a problem hiding this comment.
Do you know why? Did we misport a lemma and add this hypothesis unecessarily?
Contributor
Author
There was a problem hiding this comment.
No, I cannot find the lemma that uses it. It might be a matter of instance unification, again.
Member
There was a problem hiding this comment.
I think we're missing the fact that submonoids are inhabited (with 1) Nope, that's not it: lean3 can't find that either.
Member
There was a problem hiding this comment.
In Lean3 this finds has_one.nonempty
Contributor
Author
There was a problem hiding this comment.
No fix in sight, then?
Member
There was a problem hiding this comment.
I think TC search just times out before it finds it
Member
|
bors merge Thanks! |
bors bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
kim-em
pushed a commit
that referenced
this pull request
May 10, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
hrmacbeth
pushed a commit
that referenced
this pull request
May 10, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
hrmacbeth
pushed a commit
that referenced
this pull request
May 11, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846
group_theory.monoid_localization@1f0096e6caa61e9c849ec2adbd227e960e9dff58..13b8e258f14bffb5def542aa78b803b0b80541aa