This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(group_theory/monoid_localization): Order#18724
Closed
YaelDillies wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - feat(group_theory/monoid_localization): Order#18724YaelDillies wants to merge 6 commits intomasterfrom
YaelDillies wants to merge 6 commits intomasterfrom
Conversation
alexjbest
reviewed
Apr 4, 2023
Member
|
I guess you didn't quite do what the description says; can you add the order hom (or rel embedding or whatever it is) from the original monoid to the localisation that preserves the order when linear_ordered_cancel_comm_monoid? |
Member
|
Should it be an ordered monoid embedding...? At least if for 1. Sorry for asking so much |
Collaborator
Author
|
We don't have those (we don't even monoid embeddings). What other bundlings would you want (knowing that all the results are already there unbundled)? |
eric-wieser
reviewed
Apr 4, 2023
Member
|
Yeah maybe its fine like this, I guess we could also have order_monoid_hom that is injective. But I suppose its not needed, maybe we could just add a TODO saying if an order_monoid_embedding is implemented this is an example |
Member
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by alexjbest. |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
Thank you, that's a nice generalisation! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
Prove that every (linearly) ordered cancellative monoid can be embedded into a (linearly) ordered group, namely its Grothendieck group. Note that cancellativity is necessary since submonoids of a group are cancellative. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
Prove that every (linearly) ordered cancellative monoid can be embedded into a (linearly) ordered group, namely its Grothendieck group. Note that cancellativity is necessary since submonoids of a group are cancellative. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
YaelDillies
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 21, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 [`group_theory.monoid_localization`@`1f0096e6caa61e9c849ec2adbd227e960e9dff58`..`13b8e258f14bffb5def542aa78b803b0b80541aa`](https://leanprover-community.github.io/mathlib-port-status/file/group_theory/monoid_localization?range=1f0096e6caa61e9c849ec2adbd227e960e9dff58..13b8e258f14bffb5def542aa78b803b0b80541aa)
This was referenced Apr 21, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 24, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
hrmacbeth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
hrmacbeth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 11, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prove that every (linearly) ordered cancellative monoid can be embedded into a (linearly) ordered group, namely its Grothendieck group. Note that cancellativity is necessary since submonoids of a group are cancellative.