This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - fix(group_theory/monoid_localization): fix timeout#18846
Closed
eric-wieser wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - fix(group_theory/monoid_localization): fix timeout#18846eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser wants to merge 1 commit intomasterfrom
Conversation
Splitting this into two definitions seems to make both much fater
YaelDillies
approved these changes
Apr 21, 2023
Collaborator
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks, I was about to go and fix this myself!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
YaelDillies
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 21, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 [`group_theory.monoid_localization`@`1f0096e6caa61e9c849ec2adbd227e960e9dff58`..`13b8e258f14bffb5def542aa78b803b0b80541aa`](https://leanprover-community.github.io/mathlib-port-status/file/group_theory/monoid_localization?range=1f0096e6caa61e9c849ec2adbd227e960e9dff58..13b8e258f14bffb5def542aa78b803b0b80541aa)
Collaborator
|
bors r+ |
|
👎 Rejected by label |
Collaborator
|
Oops, I did not see that the build was not finished. Let's wait for CI then. |
Collaborator
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
|
I think there's no need to wait for CI given that this declaration was added very recently (#18724) and nothing depends on it. |
Member
Author
|
I agree; especially since anything else in the queue is likely to fail without this PR anyway bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 21, 2023
Splitting this into two definitions seems to make both much faster
YaelDillies
referenced
this pull request
Apr 21, 2023
Prove that every (linearly) ordered cancellative monoid can be embedded into a (linearly) ordered group, namely its Grothendieck group. Note that cancellativity is necessary since submonoids of a group are cancellative. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
YaelDillies
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 22, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 24, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
hrmacbeth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
hrmacbeth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 11, 2023
Match leanprover-community/mathlib3#18724 and leanprover-community/mathlib3#18846 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting this into two definitions seems to make both much faster