Skip to content

New Release v1.54.0 - #minor#1302

Merged
pakb merged 67 commits intomasterfrom
develop
Apr 16, 2025
Merged

New Release v1.54.0 - #minor#1302
pakb merged 67 commits intomasterfrom
develop

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Apr 16, 2025

ismailsunni and others added 30 commits March 25, 2025 05:33
PB-1480: Fix bug with swissearch and crosshair together
With the work done on PB-1548, we have solved a flakyness in the behavior of
the drawing module. Which means the tests did not have any issues, our code had
some issues.

We reinstate the tests so we can be warned when something is wrong
- We added a warning button in the ExtLayerInfoButton, similar to the error button
- small test to check that layers which are partially out of bound show it
- using flattenextent function to flatten the extent
- use a computed for the ExtLayerInfoButton theme
- adding forgotten font awesome icons
The tests were flaky in the way that they couldn't select the correct
elements for testing. With closing the menu and adding some assertions
of the elements being visible it seems that we slow down cypress enough
so that the selection is correct now
I will need to use the tooltip in the elevation profile module, so I've exported the component for the tooltip as a "lib"
no unit test for package tooltip, so removing targets (so that they don't get called and fail)
tailwind applies a max-width: 100% to all img tags, and that was breaking our BG wheel (S)CSS
to mitigate some edge case bug in Vue's defineTemplate function, if you name the variable the same name as the template ref it starts spewing warning message like crazy when the project is bundled/built and imported elsewhere
sami-nouidri-swisstopo and others added 20 commits April 10, 2025 17:05
Issue: When parsing a legacy link, KML layers would use the standard style. Those
KMLs were most likely designed on the old viewer, where they were rendered with the
`geoadmin` style. Users would like their KMLs to still have the same style as they used to.

Fix: When loading a legacy KML layer, we set its style to geoadmin.
…pare'

Issue : When pressing 'compare' on a map with no active layers, the user had no
feedback letting him know why the slider wasn't showing up.

Fix : Added a hint which is displayed when no layers are active
…re-slider

PB-419 : Add feedback indicating absence of layers when pressing 'compare'
adapt SCSS code to SASS 1.77.7 (see https://sass-lang.com/documentation/breaking-changes/mixed-decls/)
-> moving all "main" declaration before any nested declaration
after switching to OL v10.5.0 our code that tests a drag&drop edit of a marker is broken.
I tried all the tricks in the books but couldn't make it work again. Removing that test entirely
Some COGs we provide aren't encoded with an EPSG number in the corresponding field, but with a specific number telling us it is a "user defined CRS".
In order to be able to detect such COGs, I've added a technical name to both LV95 and LV03, which will be used to detect COGs that are in such format.
…-detection

PB-1605 : detect COG projection based on name when no EPSG found
Issue : we adapted the CSS for the generic pop up which holds the 3d features info for now
, but the styling doesn't please our users who are using the drawings.
Fix : We revert the changes and the 3d pop up will be done when we can get it
from the backend :)
still incorporating the new SMS REGEX and the fact that we need to translate the content of the feature so that the 3D building tooltip works as expected
@github-actions github-actions bot changed the title new version New Release v1.54.0 - #minor Apr 16, 2025
Copy link
Contributor

@sami-nouidri-swisstopo sami-nouidri-swisstopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pakb pakb merged commit 3ec5f79 into master Apr 16, 2025
8 checks passed
@cypress
Copy link

cypress bot commented Apr 16, 2025

web-mapviewer    Run #5053

Run Properties:  status check passed Passed #5053  •  git commit 3ec5f79839: Merge pull request #1302 from geoadmin/develop
Project web-mapviewer
Branch Review master
Run status status check passed Passed #5053
Run duration 01m 24s
Commit git commit 3ec5f79839: Merge pull request #1302 from geoadmin/develop
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants