PB-1561: revert CSS changes to generic feature pop up windows#1299
Merged
PB-1561: revert CSS changes to generic feature pop up windows#1299
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 05m 42s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
22
|
Skipped
|
0
|
Passing
|
246
|
| View all changes introduced in this branch ↗︎ | |
16e937a to
9a224f2
Compare
pakb
requested changes
Apr 16, 2025
Contributor
pakb
left a comment
There was a problem hiding this comment.
there's no more floating edit window when drawing, please fix this
Issue : we adapted the CSS for the generic pop up which holds the 3d features info for now , but the styling doesn't please our users who are using the drawings. Fix : We revert the changes and the 3d pop up will be done when we can get it from the backend :)
a82a004 to
68ec52b
Compare
still incorporating the new SMS REGEX and the fact that we need to translate the content of the feature so that the 3D building tooltip works as expected
68ec52b to
83ee819
Compare
pakb
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : we adapted the CSS for the generic pop up which holds the 3d features info for now , but the styling doesn't please our users who are using the drawings.
Fix : We revert the changes and the 3d pop up will be done when we can get it from the backend :)
Test link