Skip to content

PB-1448: add back flaky kml admin test#1280

Merged
ltkum merged 1 commit intodevelopfrom
feat-PB-1448-add-back-kml-admin-test
Mar 25, 2025
Merged

PB-1448: add back flaky kml admin test#1280
ltkum merged 1 commit intodevelopfrom
feat-PB-1448-add-back-kml-admin-test

Conversation

@ltkum
Copy link
Contributor

@ltkum ltkum commented Mar 24, 2025

With the work done on PB-1548, we have solved a flakyness in the behavior of the drawing module. Which means the tests did not have any issues, our code had some issues.

We reinstate the tests so we can be warned when something is wrong

Test link

@ltkum ltkum requested a review from pakb March 24, 2025 13:18
@cypress
Copy link

cypress bot commented Mar 24, 2025

web-mapviewer    Run #4869

Run Properties:  status check passed Passed #4869  •  git commit 11f129da0c: Merge pull request #1280 from geoadmin/feat-PB-1448-add-back-kml-admin-test
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4869
Run duration 01m 38s
Commit git commit 11f129da0c: Merge pull request #1280 from geoadmin/feat-PB-1448-add-back-kml-admin-test
Committer Martin Künzi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

@ltkum ltkum force-pushed the feat-PB-1448-add-back-kml-admin-test branch from 099e55d to 4aff7cf Compare March 24, 2025 16:52
@ltkum ltkum requested a review from pakb March 24, 2025 16:52
With the work done on PB-1548, we have solved a flakyness in the behavior of
the drawing module. Which means the tests did not have any issues, our code had
some issues.

We reinstate the tests so we can be warned when something is wrong
@ltkum ltkum force-pushed the feat-PB-1448-add-back-kml-admin-test branch from 4aff7cf to 24c51e9 Compare March 25, 2025 08:05
@ltkum ltkum merged commit 11f129d into develop Mar 25, 2025
6 checks passed
@ltkum ltkum deleted the feat-PB-1448-add-back-kml-admin-test branch March 25, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants