Skip to content

PB-1151: showing warning messages in the menu#1269

Merged
ltkum merged 2 commits intodevelopfrom
feat-PB-1551-KML-oob-warning
Mar 25, 2025
Merged

PB-1151: showing warning messages in the menu#1269
ltkum merged 2 commits intodevelopfrom
feat-PB-1551-KML-oob-warning

Conversation

@ltkum
Copy link
Contributor

@ltkum ltkum commented Mar 18, 2025

  • We added a warning button in the ExtLayerInfoButton, similar to the error button
  • small test to check that layers which are partially out of bound show it

Test link

@ltkum ltkum force-pushed the feat-PB-1551-KML-oob-warning branch from acac6e3 to bdea3c5 Compare March 18, 2025 13:06
@cypress
Copy link

cypress bot commented Mar 18, 2025

web-mapviewer    Run #4870

Run Properties:  status check passed Passed #4870  •  git commit c0686add29: Merge pull request #1269 from geoadmin/feat-PB-1551-KML-oob-warning
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4870
Run duration 01m 39s
Commit git commit c0686add29: Merge pull request #1269 from geoadmin/feat-PB-1551-KML-oob-warning
Committer Martin Künzi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

@ltkum ltkum force-pushed the feat-PB-1551-KML-oob-warning branch 4 times, most recently from 0db6f3c to 91dacd4 Compare March 21, 2025 10:49
@ltkum ltkum requested a review from pakb March 21, 2025 10:55
@ltkum ltkum force-pushed the feat-PB-1551-KML-oob-warning branch from 91dacd4 to c459912 Compare March 24, 2025 13:49
@ltkum ltkum requested a review from pakb March 24, 2025 16:15
@ltkum ltkum force-pushed the feat-PB-1551-KML-oob-warning branch from f3db17d to abb4107 Compare March 24, 2025 16:35
ltkum added 2 commits March 25, 2025 09:19
- We added a warning button in the ExtLayerInfoButton, similar to the error button
- small test to check that layers which are partially out of bound show it
- using flattenextent function to flatten the extent
- use a computed for the ExtLayerInfoButton theme
- adding forgotten font awesome icons
@ltkum ltkum force-pushed the feat-PB-1551-KML-oob-warning branch from abb4107 to eea0770 Compare March 25, 2025 08:19
@ltkum ltkum merged commit c0686ad into develop Mar 25, 2025
6 checks passed
@ltkum ltkum deleted the feat-PB-1551-KML-oob-warning branch March 25, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants