Conversation
1cbd484 to
9e3440f
Compare
I will need to use the tooltip in the elevation profile module, so I've exported the component for the tooltip as a "lib"
9e3440f to
51627e3
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 39s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
and add it to the main.scss imports
no unit test for package tooltip, so removing targets (so that they don't get called and fail)
e77f5aa to
97a094c
Compare
tailwind applies a max-width: 100% to all img tags, and that was breaking our BG wheel (S)CSS
to mitigate some edge case bug in Vue's defineTemplate function, if you name the variable the same name as the template ref it starts spewing warning message like crazy when the project is bundled/built and imported elsewhere
schtibe
left a comment
There was a problem hiding this comment.
LGTM, just a few minor remarks about details
| top: `${middlewareData.arrow.y}px`, | ||
| }" | ||
| class="tw:absolute tw:h-0 tw:w-0 tw:after:content-[''] tw:after:h-0 tw:after:w-0 tw:after:fixed tw:after:top-[inherit] tw:after:left-[inherit] tw:after:z-[-1]" | ||
| :class="{ |
There was a problem hiding this comment.
Maybe it could make sense to move this into a computed to keep the HTML part less cluttered? I think it is rather easy to construct arrays or objects that will the be passed to the attribute
There was a problem hiding this comment.
I really don't like when we mix our JS code with HTML class generation, that's why I tried to kept everything related to Tailwind described in the template section.
It could be improved a bit if moved to JS, but as I said, I prefer to keep the JS doing its part (interaction, reactivity, etc) and let the template be responsible for the styling
| @@ -0,0 +1,49 @@ | |||
| { | |||
There was a problem hiding this comment.
I think you could run a pnpm format on this file.
| @@ -0,0 +1,2 @@ | |||
| @import 'tailwindcss' prefix(tw); | |||
| @import '@geoadmin/tooltip/tailwindcss'; | |||
There was a problem hiding this comment.
Is this line doing anything?
There was a problem hiding this comment.
without it, the tailwind classes from the @geoadmin/tooltip module are ignored and not taken into account in the mapviewer package's tailwind output
|
Oh maybe you could also add the new module to |
I will need to use the tooltip in the elevation profile module, so I've exported the component for the tooltip as a "lib"
Test link