PB-419 : Add feedback indicating absence of layers when pressing 'compare'#1294
Merged
sami-nouidri-swisstopo merged 2 commits intodevelopfrom Apr 14, 2025
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 39s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
9b99ccd to
3400f5b
Compare
ltkum
reviewed
Apr 11, 2025
Contributor
ltkum
left a comment
There was a problem hiding this comment.
A few small modifications :)
packages/mapviewer/src/modules/menu/components/advancedTools/MenuAdvancedToolsList.vue
Outdated
Show resolved
Hide resolved
packages/mapviewer/src/modules/menu/components/advancedTools/MenuAdvancedToolsList.vue
Outdated
Show resolved
Hide resolved
packages/mapviewer/src/modules/menu/components/advancedTools/MenuAdvancedToolsList.vue
Outdated
Show resolved
Hide resolved
6be27bd to
5c94acb
Compare
5c94acb to
adcedb0
Compare
Luke252
reviewed
Apr 14, 2025
| "no_file": "Keine Datei", | ||
| "no_layer_found": "Keine Layer gefunden", | ||
| "no_layers_info": "Kein Layer auf der Karte", | ||
| "no_layers_info_compare" : "Sie benötigen mindestens eine sichtbare Layer, um das Vergleichstool zu verwenden.", |
There was a problem hiding this comment.
"Sie benötigen mindestens ein sichtbarer Datensatz, um das Vergleichen Werkzeug zu verwenden."
Luke252
reviewed
Apr 14, 2025
| "no_file": "Nagina datoteca", | ||
| "no_layer_found": "Nagut strato chattà", | ||
| "no_layers_info": "Nagin layer sin la charta", | ||
| "no_layers_info_compare": "Nagin layer chattà", |
There was a problem hiding this comment.
Per utilisar l'instrument da cumparaziun basegni almain ina charta activada.
49f2376 to
cd19365
Compare
…pare' Issue : When pressing 'compare' on a map with no active layers, the user had no feedback letting him know why the slider wasn't showing up. Fix : Added a hint which is displayed when no layers are active
cd19365 to
4cdcf4c
Compare
a6f941a to
540eb4c
Compare
ltkum
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : When pressing 'compare' on a map with no active layers, the user had no feedback letting him know why the slider wasn't showing up.
Fix : Added a hint which is displayed when no layers are active
Here's a preview :
Note : translation keys are temporary, needs to be confirmed with @Luke252
Test link