Skip to content

Fix flaky importToolMaps tests#1281

Merged
schtibe merged 1 commit intodevelopfrom
fix-importool-tests
Mar 27, 2025
Merged

Fix flaky importToolMaps tests#1281
schtibe merged 1 commit intodevelopfrom
fix-importool-tests

Conversation

@schtibe
Copy link
Contributor

@schtibe schtibe commented Mar 25, 2025

The tests were flaky in the way that they couldn't select the correct elements for testing. With closing the menu and adding some assertions of the elements being visible it seems that we slow down cypress enough so that the selection is correct now

Test link

The tests were flaky in the way that they couldn't select the correct
elements for testing. With closing the menu and adding some assertions
of the elements being visible it seems that we slow down cypress enough
so that the selection is correct now
@github-actions github-actions bot added the bug label Mar 25, 2025
@cypress
Copy link

cypress bot commented Mar 25, 2025

web-mapviewer    Run #4875

Run Properties:  status check passed Passed #4875  •  git commit 5d8a91e837: Merge pull request #1281 from geoadmin/fix-importool-tests
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4875
Run duration 01m 39s
Commit git commit 5d8a91e837: Merge pull request #1281 from geoadmin/fix-importool-tests
Committer Stefan Heinemann
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

@schtibe schtibe requested review from ltkum and pakb March 25, 2025 16:14
Copy link
Contributor

@ismailsunni ismailsunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schtibe schtibe merged commit 5d8a91e into develop Mar 27, 2025
6 checks passed
@schtibe schtibe deleted the fix-importool-tests branch March 27, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants