Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 24s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
adapt SCSS code to SASS 1.77.7 (see https://sass-lang.com/documentation/breaking-changes/mixed-decls/) -> moving all "main" declaration before any nested declaration
after switching to OL v10.5.0 our code that tests a drag&drop edit of a marker is broken. I tried all the tricks in the books but couldn't make it work again. Removing that test entirely
sommerfe
reviewed
Apr 15, 2025
Comment on lines
+69
to
+75
|
|
||
| &.dev-disclaimer-present { | ||
| $top-margin: calc($header-height + $dev-disclaimer-height + 1rem); | ||
| } | ||
| & { | ||
| top: $top-margin; | ||
| } |
Contributor
There was a problem hiding this comment.
Is there a lint rule that detects if the nested declarations are before the main declarations?
Contributor
Author
There was a problem hiding this comment.
that would require adding Stylelint to the project, but that could help... I'll add that to the "to-do/Christmas whishlist" in JIRA 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adapt SCSS code to SASS 1.77.7 (see https://sass-lang.com/documentation/breaking-changes/mixed-decls/) -> moving all "main" declaration before any nested declaration
Test link