PB-1494: use geoadmin style on legacy links#1290
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 39s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
pakb
approved these changes
Apr 14, 2025
Contributor
|
can you add a test somewhere in Cypress so that we cover that? |
Issue: When parsing a legacy link, KML layers would use the standard style. Those KMLs were most likely designed on the old viewer, where they were rendered with the `geoadmin` style. Users would like their KMLs to still have the same style as they used to. Fix: When loading a legacy KML layer, we set its style to geoadmin.
488e34c to
4416859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When parsing a legacy link, KML layers would use the standard style. Those KMLs were most likely designed on the old viewer, where they were rendered with the
geoadminstyle. Users would like their KMLs to still have the same style as they used to.Fix: When loading a legacy KML layer, we set its style to geoadmin.
Test link with a kml layer : TEST
same layer on geoadmin : CURRENT
Test link