add releasedOn date to new challenges#12720
add releasedOn date to new challenges#12720QuincyLarson wants to merge 154 commits intofreeCodeCamp:stagingfrom
Conversation
|
|
@systimotic I think this is ready. Please squash these commits when you merge this. |
There was a problem hiding this comment.
@QuincyLarson merging this as is would be problematic I think. See what I've noted below. This would splice 2 challenges together (object tests w/ array challenge), and it removes an additional test that was added to that last object challenge.
The content that you added in here has actually been moved up to the top as the first array challenge (it was just posted out of order on the GitHub thread).
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
OK - I've made these changes. Thank you for spotting these issues!
8389a0d to
bd88ac7
Compare
|
@no-stack-dub-sack OK - this should be good to merge. Please take another look when time permits :) |
…llenge. * Improve instruction. * Format CSS values as table. * Add additional test. * Use strict equality check.
…html Disable loopProtect for non-JavaScript code
no-stack-dub-sack
left a comment
There was a problem hiding this comment.
@QuincyLarson I hate to do it to you 😧 , because I know you've been working on this for a while, but this needs one final change....
| "assert.deepEqual((function() { delete user.data.friends; user.data.friends = ['Sam', 'Kira', 'Tomo']; return addFriend(user, 'Pete') })(), ['Sam', 'Kira', 'Tomo', 'Pete'], 'message: <code>addFriend(user, \"Pete\")</code> should return <code>[\"Sam\", \"Kira\", \"Tomo\", \"Pete\"]</code>');" | ||
| "assert('name' in user && 'age' in user && 'data' in user, 'The user object has name, age, and data keys');", | ||
| "assert((function() { let L1 = user.data.friends.length; addFriend(user, 'Sean'); let L2 = user.data.friends.length; return (L2 === L1 + 1); })(), 'The addFriend function accepts a user object and a friend as arguments and adds the friend to the array of friends in the user object.');" | ||
| ], |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
- Apply appropriate formatting for key words - Make algorithm image responsive - Apply code tags around appropriate words - Remove unnecessary semicolon in seed code - Fix test with Infinity value - Add solution to Breadth-First Search
…ion-bower update bower.json with resolution for jQuery
…atting Reformatted instructions for the first four ES6 challenges
…cription Added a comma to separate x and y coordinates pairs
Fix description of 2nd test in challenge Inventory Update
…decar Chore(package): Remove gitter-sidecar due to vulnerability
Fix create media query instructions and test
Edited label text in description and challenge code
fix(challenge): added semicolon to statement, matching characters challenge
…mar-formatting-env-challenge fix(challenge): various grammar and formatting, .env node challenge
…ion-ambiguity Reword amiguous challenge instructions
…in-function-call Ensure use of two arguments in function call
…e-tags Remove code tags from challenge seed
|
@no-stack-dub-sack Ok - I've made the fix you recommended, then rebased staging in and addressed the conflicts. Please double check, then squash and merge. |
|
@QuincyLarson This PR shows 154 commits for me, and still has merge conflicts. Is that intended? |
|
@systimotic yes - this branch has become quite ugly. I'm going branch of staging and re-apply the changes manually real quick, then put in a fresh PR. |
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Description
This adds a "releasedOn" date so they will get a "New" tag in the challenge map (though this feature has yet to be implemented in our reactified platform).
I also moved some of our retired backend projects into our "take-home practice projects" section so campers can still build them if they're looking for extra practice.
Finally, I fixed the "isRequired" flag for a couple of the intermediate algorithm challenges that were moved over from advanced algorithm challenges (and were previously un-required)