Skip to content

update bower.json with resolution for jQuery#13022

Merged
Greenheart merged 1 commit intofreeCodeCamp:stagingfrom
dhcodes:fix/jquery-resolution-bower
Feb 1, 2017
Merged

update bower.json with resolution for jQuery#13022
Greenheart merged 1 commit intofreeCodeCamp:stagingfrom
dhcodes:fix/jquery-resolution-bower

Conversation

@dhcodes
Copy link
Copy Markdown
Contributor

@dhcodes dhcodes commented Feb 1, 2017

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Added the following to the bower.json file to prevent the input prompt during local install.

"resolutions": {
    "jquery": "~3.1.1"
  }

Blew away my local instance to test locally but works 👍 💯

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 1, 2017
Copy link
Copy Markdown
Member

@Greenheart Greenheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the issue when creating a fresh clone of the repo.

@dhcodes Thanks! 😄

@Greenheart Greenheart merged commit c7c0127 into freeCodeCamp:staging Feb 1, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants