Skip to content

Reword amiguous challenge instructions#13255

Merged
erictleung merged 1 commit intofreeCodeCamp:stagingfrom
becausealice2:fix/instruction-ambiguity
Feb 12, 2017
Merged

Reword amiguous challenge instructions#13255
erictleung merged 1 commit intofreeCodeCamp:stagingfrom
becausealice2:fix/instruction-ambiguity

Conversation

@becausealice2
Copy link
Copy Markdown
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Reworded the challenge instructions for Learn About SVG in D3 to included the constants provided in the code.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 9, 2017
@erictleung
Copy link
Copy Markdown
Member

@becausealice2 LGTM! 👍 Thanks for the PR!

@erictleung erictleung merged commit b35319c into freeCodeCamp:staging Feb 12, 2017
@erictleung erictleung removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 12, 2017
@becausealice2 becausealice2 deleted the fix/instruction-ambiguity branch February 13, 2017 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants