Remove code tags from challenge seed#13198
Merged
erictleung merged 1 commit intofreeCodeCamp:stagingfrom Feb 12, 2017
Merged
Conversation
10 tasks
erictleung
suggested changes
Feb 6, 2017
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
6433f9f to
74d5682
Compare
Member
|
@erictleung this LGTM, unless you want to add anything more to the change. |
Member
|
@raisedadead if you're able to locally test this, go ahead and merge. I haven't made the time yet to get to this and pull it down locally. |
erictleung
approved these changes
Feb 12, 2017
This was referenced Sep 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Description
Removed code tags from the challenge seed, which were causing some tests to fail. Also added code tags around the ES6 function syntax in
description, to be consistent with the example above it.UPDATE -
Improved the code formatting in
description, as per Eric's suggestions. Here's the latest changes -Closes #13181