fix(challenge): various grammar and formatting, .env node challenge by no-stack-dub-sack · Pull Request #13162 · freeCodeCamp/freeCodeCamp

no-stack-dub-sack · 2017-02-05T18:08:49Z

Pre-Submission Checklist

Your pull request targets the staging branch of freeCodeCamp.
Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
You have only one commit (if not, squash them into one commit).
All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)
Add new translation (feature adding new translations)

Checklist:

Tested changes locally.
Closes currently open issue (replace XXXX with an issue no): Closes [beta] Use the .env file (basic node) - various grammar and formatting issues #13161

Description

GitHub does not seem to be highlighting my changes very well, so reviewers, please read through both for details. I think this improves the flow of the challenge, though, and fixes the following:

various language and grammar issues
wrapped variable and code references in <code> tags
separated one long paragraph into 2 shorter ones to make it a bit less daunting
clarified challenge instructions
changed confusing wording in assertion error

seed/challenges/05-apis-and-microservices/basic-node-and-express.json

erictleung

Changes look good. Just some more formatting suggestions 😄

no-stack-dub-sack · 2017-02-07T23:29:40Z

@erictleung Changes are all set! Thanks for the review! Once this one and #13155 are both reviewed and merged, #13164 could also use a review which also deals with these challenges.

no-stack-dub-sack · 2017-02-08T23:26:55Z

@erictleung is this good now then? Looks like the "changes requested" is still present so wasn't sure if there was anything else

seed/challenges/05-apis-and-microservices/basic-node-and-express.json

erictleung · 2017-02-09T01:07:02Z

@no-stack-dub-sack sorry! I didn't get the time to pull this down locally to test. I've taken another look at it and found some other changes that might be made. Sorry for the delay.

no-stack-dub-sack · 2017-02-09T02:34:27Z

@erictleung No worries! Just saw the 👍 and the 🎉 so wasn't sure... nice catches though, especially the quotes, left an explanation as to how and why that happened above in the (soon to be) outdated. Pushing the changes in a second!

seed/challenges/05-apis-and-microservices/basic-node-and-express.json

no-stack-dub-sack · 2017-02-10T00:26:21Z

@erictleung Whoops, missed that one, should be good now

erictleung · 2017-02-12T09:01:09Z

@no-stack-dub-sack LGTM! 👍 Thanks for your PR and patience!

BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 5, 2017

no-stack-dub-sack force-pushed the fix/grammar-formatting-env-challenge branch 2 times, most recently from 1d37fde to 10e1edd Compare February 5, 2017 18:33

no-stack-dub-sack mentioned this pull request Feb 5, 2017

fix(challenges): add class to backend challenge wrapper, fix basic no… #13164

Merged

10 tasks

erictleung reviewed Feb 7, 2017

View reviewed changes