fix(challenges): add class to backend challenge wrapper, fix basic no…#13164
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@no-stack-dub-sack blocking for a merge post the others? |
|
@raisedadead Yeah, sorry, meant to add the label. Once the 2 referenced above are merged, we can remove this label and review. |
|
@no-stack-dub-sack I guess we are good to go after addressing the review comments now? |
|
@raisedadead Yeah, the two PRs holding it up have been merged and the comments from above have been addressed, but I don't think anyone's given it a full review yet Sorry for the late reply, I didn't see that the last PR holding it up had been merged |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@no-stack-dub-sack these changes LGTM, except for some formatting overhaul. Would you be interested in doing so via this PR. Or we could take up later, I'll leave the choice to you. |
|
@raisedadead Where, in the entire backend section? Or just in the section that I've already modified. Because as you know, I've only done basic node and express here, and the entire backend curriculum has code examples that also need to be wrapped in blockquotes. So I can do it for this section, but I think maybe the other sections should have everything done at once |
1769c8e to
9ec760f
Compare
|
@raisedadead Ok, I've made some updates, I think I caught most of everything, but not sure if some things like POST and GET should be wrapped in code tags to have them stand apart even when they're not explicitly in the context of code. They are also mentioned in this section several times before they're actually introduced, so maybe this could use some re-working and DFN tags in the right places. This also will now close #13168 which I opened a while ago. |
|
@raisedadead Did you get a chance to check out the changes I made since we last checked in? |
|
@no-stack-dub-sack sorry have been travelling a bit last weekend. LGTM. Lets add more formatting in further PR's. I am yet to pull down locally and merge it in. I am okay if anyone beats me to it. |
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Also closes [beta] confusing instructions in Root-level Request Logger challenge - Basic Node #13168
Description
.challenge-instructionsto the<Row>component surrounding the function that renders challenge instructions in the new backend challenge component<blockquote>s to exemplify the changes and for consistency with rest of challenge seed<dfn>tags in this section which previously would not have formatted correctlyNOTE:
I think this may cause some merge conflicts in other PRs if merged before them. #13155 and #13162 should be merged first to avoid this I believe.