Skip to content

Ensure use of two arguments in function call#13295

Merged
erictleung merged 1 commit intofreeCodeCamp:stagingfrom
Manish-Giri:fix/arguments-in-function-call
Feb 12, 2017
Merged

Ensure use of two arguments in function call#13295
erictleung merged 1 commit intofreeCodeCamp:stagingfrom
Manish-Giri:fix/arguments-in-function-call

Conversation

@Manish-Giri
Copy link
Copy Markdown
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Amended the test to ensure that two numbers are passed as arguments, for the challenge to pass.

Tested locally - with the new test, the following conditions do not pass:

  1. Function call with no arguments - functionWithArgs();
  2. Function call with a space as argument(worked earlier, as reported by OP) - functionWithArgs( );
  3. Function call with only one number as argument - functionWithArgs(8 );

Also updated the challenge instruction to specify that two numbers must be passed as function arguments.

Closes #13280

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 12, 2017
@erictleung
Copy link
Copy Markdown
Member

@Manish-Giri works perfectly! LGTM! 👍 Thanks for the PR!

@erictleung erictleung merged commit e1bcb69 into freeCodeCamp:staging Feb 12, 2017
@erictleung erictleung removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants