Ensure use of two arguments in function call#13295
Merged
erictleung merged 1 commit intofreeCodeCamp:stagingfrom Feb 12, 2017
Merged
Ensure use of two arguments in function call#13295erictleung merged 1 commit intofreeCodeCamp:stagingfrom
erictleung merged 1 commit intofreeCodeCamp:stagingfrom
Conversation
erictleung
approved these changes
Feb 12, 2017
Member
|
@Manish-Giri works perfectly! LGTM! 👍 Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Description
Amended the test to ensure that two numbers are passed as arguments, for the challenge to pass.
Tested locally - with the new test, the following conditions do not pass:
functionWithArgs();functionWithArgs( );functionWithArgs(8 );Also updated the challenge instruction to specify that two numbers must be passed as function arguments.
Closes #13280