Skip to content

Edited label text in description and challenge code#13287

Merged
dhcodes merged 1 commit intofreeCodeCamp:stagingfrom
cdrani:fix/edit-label-text
Feb 12, 2017
Merged

Edited label text in description and challenge code#13287
dhcodes merged 1 commit intofreeCodeCamp:stagingfrom
cdrani:fix/edit-label-text

Conversation

@cdrani
Copy link
Copy Markdown

@cdrani cdrani commented Feb 11, 2017

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

I removed the MM-DD-YYYY text in the description and challenge code label texts as the date picker date format is region-based and it wouldn't ring true for all campers.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 11, 2017
@dhcodes
Copy link
Copy Markdown
Contributor

dhcodes commented Feb 12, 2017

Tested locally and LGTM. Thanks for contributing @cdrainxv ! 🌮 💯 🏎

@dhcodes dhcodes merged commit 34280a7 into freeCodeCamp:staging Feb 12, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 12, 2017
@teeleek
Copy link
Copy Markdown

teeleek commented Feb 12, 2017 via email

@cdrani cdrani deleted the fix/edit-label-text branch February 12, 2017 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants