Skip to content

Added a comma to separate x and y coordinates pairs#13028

Merged
Greenheart merged 1 commit intofreeCodeCamp:stagingfrom
cdrani:fix/short-fix-description
Feb 1, 2017
Merged

Added a comma to separate x and y coordinates pairs#13028
Greenheart merged 1 commit intofreeCodeCamp:stagingfrom
cdrani:fix/short-fix-description

Conversation

@cdrani
Copy link
Copy Markdown

@cdrani cdrani commented Feb 1, 2017

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Added a comma to separate x and y data points for the text inside of the text element. The previous code would end up adding the the x and y values into a singular value as the text to display for the text element.

Previous code and output:

.text((d) =>  (d[0] + 
 + d[1]))

screen shot 2017-02-01 at 07 47 41

Current code and output:

.text((d) =>  (d[0] + ", "
 + d[1]))

screen shot 2017-02-01 at 07 46 38

Now x and y data points displayed as text are separated by a comma.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 1, 2017
@Greenheart Greenheart self-requested a review February 1, 2017 16:05
Copy link
Copy Markdown
Member

@Greenheart Greenheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdrainxv Thanks for fixing this! 😊 🥇

@Greenheart Greenheart merged commit 64c42e5 into freeCodeCamp:staging Feb 1, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 1, 2017
@cdrani cdrani deleted the fix/short-fix-description branch February 1, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants