Disable loopProtect for non-JavaScript code#12995
Merged
Greenheart merged 1 commit intostagingfrom Jan 31, 2017
unknown repository
Merged
Disable loopProtect for non-JavaScript code#12995Greenheart merged 1 commit intostagingfrom unknown repository
Greenheart merged 1 commit intostagingfrom
unknown repository
Conversation
Greenheart
suggested changes
Jan 31, 2017
Member
Greenheart
left a comment
There was a problem hiding this comment.
@leonfeng Thanks for fixing this! I can confirm that this solves the issue.
I've just got a small suggestion for how we could improve readability before we merge this 😄
client/rechallenge/transformers.js
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Author
|
@Greenheart Learned something new~ I didn't even know |
Greenheart
approved these changes
Jan 31, 2017
Member
Greenheart
left a comment
There was a problem hiding this comment.
@leonfeng ES6 goodness! 😄
Thanks again!
Member
|
Thanks for fixing this @leonfeng! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Description
Workaround for loopProtect triggering in HTML code: disable it for pure markup that contains no
<script>tags.