Update EUI to v114.0.0#259497
Conversation
|
buildkite test this |
1 similar comment
|
buildkite test this |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
|
buildkite test this |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
|
Pinging @elastic/eui-team (EUI) |
jeramysoucy
left a comment
There was a problem hiding this comment.
Kibana Security domain changes LGTM
…ory" This reverts commit ed8273b.
6fe50ff to
b019a02
Compare
…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch
...latform/plugins/shared/discover/test/scout/ui/fixtures/traces_experience/page_objects/apm.ts
Show resolved
Hide resolved
...doc_viewer/public/components/observability/traces/components/full_screen_waterfall/index.tsx
Show resolved
Hide resolved
.../shared/discover/test/scout/ui/parallel_tests/traces_experience/flyout_cascade_close.spec.ts
Show resolved
Hide resolved
iblancof
left a comment
There was a problem hiding this comment.
Thanks for applying the suggested change to useFlyoutHistoryKey!
|
Hey @tsullivan 👋🏻 The CI was failing: It seems that Thanks, folks! |
Wow, I don't know how that happened. Confusion from a lot of indentation/whitespace changes, I guess. Thanks for catching it and fixing it! It all looks good now, I reviewed with the setting to hide whitespace changes. The latest doc_viewer code LGTM |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @acstll |
…heck * commit '6f040b29a5220ce12886a9731f656613e50aff06': (34 commits) [Entity Analytics] Add entity resolution UI to service flyout (elastic#260504) [Dashboard] Fix setState in embeddables (elastic#260082) [EDR Workflows] Unskip FTR tests that failed due to transient Fleet service unavailability (elastic#260519) [Observability:Streams] Fix query streams error handling test (elastic#260777) [Alerting v2] Dispatcher grouping modes, throttle strategies, and matcher autosuggestion (elastic#260249) [Dashboard] State extraction as a consistent override (elastic#259839) [Alerting v2] [Rule authoring] Fix rule name validation and error visibility in create/edit flow (elastic#260337) [Fix] re-introduce sln breadcrumbs to unified rules (elastic#260289) [Security Solution][Endpoint] Updated kibana docs to include `xpack.securitySolution.maxEndpointScriptFileSize` as configurable in cloud (elastic#260568) [Alerting v2] updated the alerting-v2-constants package with artifacts constants, fix to the runbook max characters (elastic#260342) [Automatic Import V2] Provide user tooltips (elastic#260725) [One Workflow] Deduplicate step types by base type in workflow list (elastic#260763) [Security Solution] Execution results UI: Enable the feature flag (elastic#260711) [Metrics][Discover] internal/search/esql_async returns 200 but METRICS_INFO responds with error (elastic#260746) Collapse redundant anyOf/oneOf array unions in OAS query params (elastic#260585) [Unified rules] Hide stack rules from global search (elastic#260088) [Agent Builder] Sidebar navigation updates (elastic#260728) [* As Code] Use PUT for upserts (elastic#260318) Update EUI to v114.0.0 (elastic#259497) [Entity Resolution] Add contextual-security-apps as co-owner of resolution paths (elastic#260659) ... # Conflicts: # src/platform/plugins/shared/dashboard/public/index.ts
…2171) ## Summary - Closes elastic/kibana-team#2566 - Includes #260557 (for history group support in the example plugin app) - [x] Hold until after #259497 ### Changes **`data-test-subj` attributes** — Added to flyout buttons, switches, and close controls in both the EuiFlyout component and Overlays API implementations to enable reliable test selectors. **Scout UI tests** — Two tests covering: - Open a main flyout and a child flyout, verify cascade close behavior - Open a push flyout, open a second overlay flyout, verify Back button navigation **Minor Flyout System Examples plugin app refactoring** - See #252171 (comment) ### To run locally ```bash node scripts/scout.js start-server \ --arch stateful \ --domain classic \ --serverConfigSet examples # terminal two: run the tests npx playwright test --config examples/flyout_system/test/scout_examples/ui/playwright.config.ts \ --project local \ --grep @local-stateful-classic \ --headed ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Dependency updates - `@elastic/eui` - v113.3.0 ⏩ v114.0.0 - `@elastic/eui-theme-borealis` - v6.2.0 ⏩ v7.0.0 - `@elastic/eslint-plugin-eui` - v2.10.0 ⏩ v2.11.0 --- ## Package updates ### [`v114.0.0`](https://github.com/elastic/eui/releases/v114.0.0) - Fixed the clipping of `EuiFlyout` overlay mask to the container bounds when the `container` prop is provided, so the mask no longer covers the full viewport for app-scoped flyouts. ([elastic#9512](elastic/eui#9512)) - Updated `EuiFlyout` to support `pushAnimation` prop for `type="overlay"` ([elastic#9428](elastic/eui#9428)) - Added `hasAnimation` prop on `EuiFlyout` (replaces `pushAnimation`) ([elastic#9428](elastic/eui#9428)) - Added `hasAnimation` prop on `EuiOverlayMask` to conditionally add animation styles ([elastic#9428](elastic/eui#9428)) - Added `historyKey` prop (type `symbol`) to `EuiFlyout` and the flyout manager API to support scoped flyout history. ([elastic#9413](elastic/eui#9413)) - Only flyouts sharing the same `Symbol` reference share Back button navigation and history entries; omitting `historyKey` gives each session its own isolated history group. - `ACTION_CLOSE_ALL` now closes only the current history group rather than all open flyouts. **Bug fixes** - Fixed `EuiTreeView` expanded nodes clipping content and causing sibling overlap when children exceed viewport height ([elastic#9510](elastic/eui#9510)) - Fixed `EuiDataGrid` scroll bouncing back to the focused element in certain cases ([elastic#9453](elastic/eui#9453)) - Fixed support for intraword underscores in `EuiMarkdownFormat` ([elastic#9408](elastic/eui#9408)) **Deprecations** - Deprecated `pushAnimation` prop on `EuiFlyout`. Use `hasAnimation` instead. ([elastic#9428](elastic/eui#9428)) **Breaking changes** - Removed `severity.assistance` color token ([elastic#9507](elastic/eui#9507)) - Removed assistance datavis color tokens: ([elastic#9507](elastic/eui#9507)) - `vis.euiColorVisAssistance` - `vis.euiColorVis10` - `vis.euiColorVis11` - `vis.euiColorVisText10` - `vis.euiColorVisText11` - `vis.euiColorVisBehindText10` - `vis.euiColorVisBehindText11` - The positional signature of `FlyoutManagerApi.addFlyout` and the flyout store's `addFlyout` now includes `historyKey` before the `iconType`/`minWidth` arguments. Call sites that pass arguments positionally must be updated (or switched to named parameters) to account for this new parameter ordering. ([elastic#9413](elastic/eui#9413)) **Accessibility** - Fixed `aria-label` not being applied to `EuiColorPicker`'s input element ([elastic#9436](elastic/eui#9436)) ### @elastic/eui-theme-borealis v7.0.0 **Breaking changes** - Removed `severity.assistance` color token ([elastic#9507](elastic/eui#9507)) - Removed assistance datavis color tokens: ([elastic#9507](elastic/eui#9507)) - `vis.euiColorVisAssistance` - `vis.euiColorVis10` - `vis.euiColorVis11` - `vis.euiColorVisText10` - `vis.euiColorVisText11` - `vis.euiColorVisBehindText10` - `vis.euiColorVisBehindText11` ### @elastic/eslint-plugin-eui v2.11.0 - Updated `no-unnamed-interactive-element` to include checking `EuiColorPicker` ([elastic#9436](elastic/eui#9436)) --------- Co-authored-by: Timothy Sullivan <tsullivan@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Weronika Olejniczak <32842468+weronikaolejniczak@users.noreply.github.com> Co-authored-by: Weronika Olejniczak <weronika.olejniczak@elastic.co>
## Dependency updates - `@elastic/eui` - v113.3.0 ⏩ v114.0.0 - `@elastic/eui-theme-borealis` - v6.2.0 ⏩ v7.0.0 - `@elastic/eslint-plugin-eui` - v2.10.0 ⏩ v2.11.0 --- ## Package updates ### [`v114.0.0`](https://github.com/elastic/eui/releases/v114.0.0) - Fixed the clipping of `EuiFlyout` overlay mask to the container bounds when the `container` prop is provided, so the mask no longer covers the full viewport for app-scoped flyouts. ([elastic#9512](elastic/eui#9512)) - Updated `EuiFlyout` to support `pushAnimation` prop for `type="overlay"` ([elastic#9428](elastic/eui#9428)) - Added `hasAnimation` prop on `EuiFlyout` (replaces `pushAnimation`) ([elastic#9428](elastic/eui#9428)) - Added `hasAnimation` prop on `EuiOverlayMask` to conditionally add animation styles ([elastic#9428](elastic/eui#9428)) - Added `historyKey` prop (type `symbol`) to `EuiFlyout` and the flyout manager API to support scoped flyout history. ([elastic#9413](elastic/eui#9413)) - Only flyouts sharing the same `Symbol` reference share Back button navigation and history entries; omitting `historyKey` gives each session its own isolated history group. - `ACTION_CLOSE_ALL` now closes only the current history group rather than all open flyouts. **Bug fixes** - Fixed `EuiTreeView` expanded nodes clipping content and causing sibling overlap when children exceed viewport height ([elastic#9510](elastic/eui#9510)) - Fixed `EuiDataGrid` scroll bouncing back to the focused element in certain cases ([elastic#9453](elastic/eui#9453)) - Fixed support for intraword underscores in `EuiMarkdownFormat` ([elastic#9408](elastic/eui#9408)) **Deprecations** - Deprecated `pushAnimation` prop on `EuiFlyout`. Use `hasAnimation` instead. ([elastic#9428](elastic/eui#9428)) **Breaking changes** - Removed `severity.assistance` color token ([elastic#9507](elastic/eui#9507)) - Removed assistance datavis color tokens: ([elastic#9507](elastic/eui#9507)) - `vis.euiColorVisAssistance` - `vis.euiColorVis10` - `vis.euiColorVis11` - `vis.euiColorVisText10` - `vis.euiColorVisText11` - `vis.euiColorVisBehindText10` - `vis.euiColorVisBehindText11` - The positional signature of `FlyoutManagerApi.addFlyout` and the flyout store's `addFlyout` now includes `historyKey` before the `iconType`/`minWidth` arguments. Call sites that pass arguments positionally must be updated (or switched to named parameters) to account for this new parameter ordering. ([elastic#9413](elastic/eui#9413)) **Accessibility** - Fixed `aria-label` not being applied to `EuiColorPicker`'s input element ([elastic#9436](elastic/eui#9436)) ### @elastic/eui-theme-borealis v7.0.0 **Breaking changes** - Removed `severity.assistance` color token ([elastic#9507](elastic/eui#9507)) - Removed assistance datavis color tokens: ([elastic#9507](elastic/eui#9507)) - `vis.euiColorVisAssistance` - `vis.euiColorVis10` - `vis.euiColorVis11` - `vis.euiColorVisText10` - `vis.euiColorVisText11` - `vis.euiColorVisBehindText10` - `vis.euiColorVisBehindText11` ### @elastic/eslint-plugin-eui v2.11.0 - Updated `no-unnamed-interactive-element` to include checking `EuiColorPicker` ([elastic#9436](elastic/eui#9436)) --------- Co-authored-by: Timothy Sullivan <tsullivan@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Weronika Olejniczak <32842468+weronikaolejniczak@users.noreply.github.com> Co-authored-by: Weronika Olejniczak <weronika.olejniczak@elastic.co>
…stic#252171) ## Summary - Closes elastic/kibana-team#2566 - Includes elastic#260557 (for history group support in the example plugin app) - [x] Hold until after elastic#259497 ### Changes **`data-test-subj` attributes** — Added to flyout buttons, switches, and close controls in both the EuiFlyout component and Overlays API implementations to enable reliable test selectors. **Scout UI tests** — Two tests covering: - Open a main flyout and a child flyout, verify cascade close behavior - Open a push flyout, open a second overlay flyout, verify Back button navigation **Minor Flyout System Examples plugin app refactoring** - See elastic#252171 (comment) ### To run locally ```bash node scripts/scout.js start-server \ --arch stateful \ --domain classic \ --serverConfigSet examples # terminal two: run the tests npx playwright test --config examples/flyout_system/test/scout_examples/ui/playwright.config.ts \ --project local \ --grep @local-stateful-classic \ --headed ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
EUI v114 introduced pointer-events: none on EuiPopover panels during
open animations. JSDOM doesn't fire CSS transitionend events, so the
property removal is timing-dependent, causing userEvent.click to
intermittently fail. Use userEvent.setup({ pointerEventsCheck: 0 })
matching the existing pattern in other Kibana tests.
Not backporting, as following the original EUI PR
#259497
Created due to it failing on main:
https://buildkite.com/elastic/kibana-on-merge/builds/92848#019d62ac-39f7-4ade-90c9-baf043ccc5ae
Resolves #259669
Dependency updates
@elastic/eui- v113.3.0 ⏩ v114.0.0@elastic/eui-theme-borealis- v6.2.0 ⏩ v7.0.0@elastic/eslint-plugin-eui- v2.10.0 ⏩ v2.11.0Package updates
v114.0.0EuiFlyoutoverlay mask to the container bounds when thecontainerprop is provided, so the mask no longer covers the full viewport for app-scoped flyouts. (#9512)EuiFlyoutto supportpushAnimationprop fortype="overlay"(#9428)hasAnimationprop onEuiFlyout(replacespushAnimation) (#9428)hasAnimationprop onEuiOverlayMaskto conditionally add animation styles (#9428)historyKeyprop (typesymbol) toEuiFlyoutand the flyout manager API to support scoped flyout history. (#9413)Symbolreference share Back button navigation and history entries; omittinghistoryKeygives each session its own isolated history group.ACTION_CLOSE_ALLnow closes only the current history group rather than all open flyouts.Bug fixes
EuiTreeViewexpanded nodes clipping content and causing sibling overlap when children exceed viewport height (#9510)EuiDataGridscroll bouncing back to the focused element in certain cases (#9453)EuiMarkdownFormat(#9408)Deprecations
pushAnimationprop onEuiFlyout. UsehasAnimationinstead. (#9428)Breaking changes
severity.assistancecolor token (#9507)vis.euiColorVisAssistancevis.euiColorVis10vis.euiColorVis11vis.euiColorVisText10vis.euiColorVisText11vis.euiColorVisBehindText10vis.euiColorVisBehindText11FlyoutManagerApi.addFlyoutand the flyout store'saddFlyoutnow includeshistoryKeybefore theiconType/minWidtharguments. Call sites that pass arguments positionally must be updated (or switched to named parameters) to account for this new parameter ordering. (#9413)Accessibility
aria-labelnot being applied toEuiColorPicker's input element (#9436)@elastic/eui-theme-borealis v7.0.0
Breaking changes
severity.assistancecolor token (#9507)vis.euiColorVisAssistancevis.euiColorVis10vis.euiColorVis11vis.euiColorVisText10vis.euiColorVisText11vis.euiColorVisBehindText10vis.euiColorVisBehindText11@elastic/eslint-plugin-eui v2.11.0
no-unnamed-interactive-elementto include checkingEuiColorPicker(#9436)