[Flyouts Example Plugin] Use historyKey for flyout demos#260557
Closed
tsullivan wants to merge 19 commits intoelastic:mainfrom
Closed
[Flyouts Example Plugin] Use historyKey for flyout demos#260557tsullivan wants to merge 19 commits intoelastic:mainfrom
tsullivan wants to merge 19 commits intoelastic:mainfrom
Conversation
…ory" This reverts commit ed8273b.
…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
1 task
Member
Author
|
Making this part of #252171 |
tsullivan
added a commit
that referenced
this pull request
Apr 2, 2026
…2171) ## Summary - Closes elastic/kibana-team#2566 - Includes #260557 (for history group support in the example plugin app) - [x] Hold until after #259497 ### Changes **`data-test-subj` attributes** — Added to flyout buttons, switches, and close controls in both the EuiFlyout component and Overlays API implementations to enable reliable test selectors. **Scout UI tests** — Two tests covering: - Open a main flyout and a child flyout, verify cascade close behavior - Open a push flyout, open a second overlay flyout, verify Back button navigation **Minor Flyout System Examples plugin app refactoring** - See #252171 (comment) ### To run locally ```bash node scripts/scout.js start-server \ --arch stateful \ --domain classic \ --serverConfigSet examples # terminal two: run the tests npx playwright test --config examples/flyout_system/test/scout_examples/ui/playwright.config.ts \ --project local \ --grep @local-stateful-classic \ --headed ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
…stic#252171) ## Summary - Closes elastic/kibana-team#2566 - Includes elastic#260557 (for history group support in the example plugin app) - [x] Hold until after elastic#259497 ### Changes **`data-test-subj` attributes** — Added to flyout buttons, switches, and close controls in both the EuiFlyout component and Overlays API implementations to enable reliable test selectors. **Scout UI tests** — Two tests covering: - Open a main flyout and a child flyout, verify cascade close behavior - Open a push flyout, open a second overlay flyout, verify Back button navigation **Minor Flyout System Examples plugin app refactoring** - See elastic#252171 (comment) ### To run locally ```bash node scripts/scout.js start-server \ --arch stateful \ --domain classic \ --serverConfigSet examples # terminal two: run the tests npx playwright test --config examples/flyout_system/test/scout_examples/ui/playwright.config.ts \ --project local \ --grep @local-stateful-classic \ --headed ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EUI v114 brought changes to the way that flyouts can have a shared history: each flyout needs to share a
historyKeyobject with the flyouts that it wants to share history with.This PR follows that concept for the flyouts in the example plugin.
Screenshots
This PR also cleans up the example page code by putting the "Non-Session" flyouts in their own section, and removing the unnecessary filler text at the bottom.
Before
After
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.