[Flyout System] Automated functional tests using Scout framework#252171
[Flyout System] Automated functional tests using Scout framework#252171tsullivan merged 19 commits intoelastic:mainfrom
Conversation
|
changed to draft since the new tests are not running in CI |
|
@tsullivan We currently don't have automatic discovery for scout tests under The question is how you would like to run those tests in CI, together with other functional tests or is there any specific goals? |
@dmlemeshko, similar to the existing example plugin tests, we would like to run these tests as part of the regular CI run. With these tests, we want to make sure that our core and Chrome APIs are stable without relying on testing specific user concerns of the apps that we don't own. |
|
@dmlemeshko would you be able to help with ensuring this test can run in CI? Would that work have to be separate or can a change be made in this PR that would enable it? |
We would have to do it in the separate PR, checking details with the Team |
...hared/kbn-scout/src/servers/configs/config_sets/examples/stateful/classic.stateful.config.ts
Show resolved
Hide resolved
cf72006 to
abe3625
Compare
abe3625 to
6373eff
Compare
|
|
||
| test.afterAll(() => { | ||
| throw new Error(`Test error to verify CI run`); | ||
| }); |
There was a problem hiding this comment.
This will ensure that CI is running Scout tests for example plugins, and is to prove useful after #259170
bf0379c to
c978c85
Compare
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
examples/flyout_system/public/components/_flyout_with_component.tsx
Outdated
Show resolved
Hide resolved
examples/flyout_system/public/components/_flyout_with_overlays.tsx
Outdated
Show resolved
Hide resolved
examples/flyout_system/public/components/_flyout_with_overlays.tsx
Outdated
Show resolved
Hide resolved
|
I used Switched to camelCase name (taking from plugin.id) in 31b2cf3 |
|
I wish to wait to merge this until after #259497, because the "scoped history" changes coming in will affect the test flow (we will need to add |
|
This brings in #260557, to add support for history groups, which functionally changed after Kibana upgraded to EUI 114. Description from that PR: SummaryEUI v114 brought changes to the way that flyouts can have a shared history: each flyout needs to share a ScreenshotsThis PR also cleans up the example page code by putting the "Non-Session" flyouts in their own section, and removing the unnecessary filler text at the bottom. Before
After
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
…stic#252171) ## Summary - Closes elastic/kibana-team#2566 - Includes elastic#260557 (for history group support in the example plugin app) - [x] Hold until after elastic#259497 ### Changes **`data-test-subj` attributes** — Added to flyout buttons, switches, and close controls in both the EuiFlyout component and Overlays API implementations to enable reliable test selectors. **Scout UI tests** — Two tests covering: - Open a main flyout and a child flyout, verify cascade close behavior - Open a push flyout, open a second overlay flyout, verify Back button navigation **Minor Flyout System Examples plugin app refactoring** - See elastic#252171 (comment) ### To run locally ```bash node scripts/scout.js start-server \ --arch stateful \ --domain classic \ --serverConfigSet examples # terminal two: run the tests npx playwright test --config examples/flyout_system/test/scout_examples/ui/playwright.config.ts \ --project local \ --grep @local-stateful-classic \ --headed ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>


Summary
Changes
data-test-subjattributes — Added to flyout buttons, switches, and close controls in both the EuiFlyout component and Overlays API implementations to enable reliable test selectors.Scout UI tests — Two tests covering:
Minor Flyout System Examples plugin app refactoring
To run locally