fixing timelion yaxis min setting by ppisljar · Pull Request #9428 · elastic/kibana

ppisljar · 2016-12-09T16:03:32Z

Timelion enforces 0 as minimum when .yaxis() is defined and min setting is not provided.
This PR removes that. If min is not provided it is left undefined. This allows negative values to be displayed and it also matches the behavior when .yaxis() is not defined.

fixes #9040

ppisljar · 2016-12-12T11:42:14Z

jenkins, test this

thomasneirynck · 2016-12-13T19:47:48Z

not sure if I'm reproducing this bug right, but it seems to still occur with this PR.

consider (using makelogs data)

The negative values disappear: .es(*) .es(offset=-1w).subtract(10000).yaxis()

Adding a default min:, and the negative values reappear: .es(*) .es(offset=-1w).subtract(10000).yaxis(min:)

ppisljar · 2016-12-14T09:14:12Z

@thomasneirynck I can't reproduce using exact query you are using. Seems just like if you wouldn't have this PR loaded. Can you try checking it out again or sth ?

tbragin · 2016-12-15T23:54:02Z

I double-checked that i have the PR checked out and i don't see the problem as fixed either:

ppisljar · 2016-12-19T13:13:06Z

weird ....

i rebased on master .... hope it helps

kobelb

I can confirm that the changes you made appear to have fixed this behavior. However, I'm hesitant to give this an approval/LGTM before @rashidkpc weighs in on why he defaulted this to 0 initially.

rashidkpc · 2016-12-21T19:00:29Z

There's no problem getting rid of that default, and there was never any good reason for enforcing it in the first place.

kobelb

looks good to Rashid, LGTM!

Backports PR #9428 **Commit 1:** fixing timelion yaxis min setting * Original sha: 9a3c8e8 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-09T15:58:29Z

## Dependency updates - `@elastic/eui` - v113.3.0 ⏩ v114.0.0 - `@elastic/eui-theme-borealis` - v6.2.0 ⏩ v7.0.0 - `@elastic/eslint-plugin-eui` - v2.10.0 ⏩ v2.11.0 --- ## Package updates ### [`v114.0.0`](https://github.com/elastic/eui/releases/v114.0.0) - Fixed the clipping of `EuiFlyout` overlay mask to the container bounds when the `container` prop is provided, so the mask no longer covers the full viewport for app-scoped flyouts. ([#9512](elastic/eui#9512)) - Updated `EuiFlyout` to support `pushAnimation` prop for `type="overlay"` ([#9428](elastic/eui#9428)) - Added `hasAnimation` prop on `EuiFlyout` (replaces `pushAnimation`) ([#9428](elastic/eui#9428)) - Added `hasAnimation` prop on `EuiOverlayMask` to conditionally add animation styles ([#9428](elastic/eui#9428)) - Added `historyKey` prop (type `symbol`) to `EuiFlyout` and the flyout manager API to support scoped flyout history. ([#9413](elastic/eui#9413)) - Only flyouts sharing the same `Symbol` reference share Back button navigation and history entries; omitting `historyKey` gives each session its own isolated history group. - `ACTION_CLOSE_ALL` now closes only the current history group rather than all open flyouts. **Bug fixes** - Fixed `EuiTreeView` expanded nodes clipping content and causing sibling overlap when children exceed viewport height ([#9510](elastic/eui#9510)) - Fixed `EuiDataGrid` scroll bouncing back to the focused element in certain cases ([#9453](elastic/eui#9453)) - Fixed support for intraword underscores in `EuiMarkdownFormat` ([#9408](elastic/eui#9408)) **Deprecations** - Deprecated `pushAnimation` prop on `EuiFlyout`. Use `hasAnimation` instead. ([#9428](elastic/eui#9428)) **Breaking changes** - Removed `severity.assistance` color token ([#9507](elastic/eui#9507)) - Removed assistance datavis color tokens: ([#9507](elastic/eui#9507)) - `vis.euiColorVisAssistance` - `vis.euiColorVis10` - `vis.euiColorVis11` - `vis.euiColorVisText10` - `vis.euiColorVisText11` - `vis.euiColorVisBehindText10` - `vis.euiColorVisBehindText11` - The positional signature of `FlyoutManagerApi.addFlyout` and the flyout store's `addFlyout` now includes `historyKey` before the `iconType`/`minWidth` arguments. Call sites that pass arguments positionally must be updated (or switched to named parameters) to account for this new parameter ordering. ([#9413](elastic/eui#9413)) **Accessibility** - Fixed `aria-label` not being applied to `EuiColorPicker`'s input element ([#9436](elastic/eui#9436)) ### @elastic/eui-theme-borealis v7.0.0 **Breaking changes** - Removed `severity.assistance` color token ([#9507](elastic/eui#9507)) - Removed assistance datavis color tokens: ([#9507](elastic/eui#9507)) - `vis.euiColorVisAssistance` - `vis.euiColorVis10` - `vis.euiColorVis11` - `vis.euiColorVisText10` - `vis.euiColorVisText11` - `vis.euiColorVisBehindText10` - `vis.euiColorVisBehindText11` ### @elastic/eslint-plugin-eui v2.11.0 - Updated `no-unnamed-interactive-element` to include checking `EuiColorPicker` ([#9436](elastic/eui#9436)) --------- Co-authored-by: Timothy Sullivan <tsullivan@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Weronika Olejniczak <32842468+weronikaolejniczak@users.noreply.github.com> Co-authored-by: Weronika Olejniczak <weronika.olejniczak@elastic.co>

## Dependency updates - `@elastic/eui` - v113.3.0 ⏩ v114.0.0 - `@elastic/eui-theme-borealis` - v6.2.0 ⏩ v7.0.0 - `@elastic/eslint-plugin-eui` - v2.10.0 ⏩ v2.11.0 --- ## Package updates ### [`v114.0.0`](https://github.com/elastic/eui/releases/v114.0.0) - Fixed the clipping of `EuiFlyout` overlay mask to the container bounds when the `container` prop is provided, so the mask no longer covers the full viewport for app-scoped flyouts. ([elastic#9512](elastic/eui#9512)) - Updated `EuiFlyout` to support `pushAnimation` prop for `type="overlay"` ([elastic#9428](elastic/eui#9428)) - Added `hasAnimation` prop on `EuiFlyout` (replaces `pushAnimation`) ([elastic#9428](elastic/eui#9428)) - Added `hasAnimation` prop on `EuiOverlayMask` to conditionally add animation styles ([elastic#9428](elastic/eui#9428)) - Added `historyKey` prop (type `symbol`) to `EuiFlyout` and the flyout manager API to support scoped flyout history. ([elastic#9413](elastic/eui#9413)) - Only flyouts sharing the same `Symbol` reference share Back button navigation and history entries; omitting `historyKey` gives each session its own isolated history group. - `ACTION_CLOSE_ALL` now closes only the current history group rather than all open flyouts. **Bug fixes** - Fixed `EuiTreeView` expanded nodes clipping content and causing sibling overlap when children exceed viewport height ([elastic#9510](elastic/eui#9510)) - Fixed `EuiDataGrid` scroll bouncing back to the focused element in certain cases ([elastic#9453](elastic/eui#9453)) - Fixed support for intraword underscores in `EuiMarkdownFormat` ([elastic#9408](elastic/eui#9408)) **Deprecations** - Deprecated `pushAnimation` prop on `EuiFlyout`. Use `hasAnimation` instead. ([elastic#9428](elastic/eui#9428)) **Breaking changes** - Removed `severity.assistance` color token ([elastic#9507](elastic/eui#9507)) - Removed assistance datavis color tokens: ([elastic#9507](elastic/eui#9507)) - `vis.euiColorVisAssistance` - `vis.euiColorVis10` - `vis.euiColorVis11` - `vis.euiColorVisText10` - `vis.euiColorVisText11` - `vis.euiColorVisBehindText10` - `vis.euiColorVisBehindText11` - The positional signature of `FlyoutManagerApi.addFlyout` and the flyout store's `addFlyout` now includes `historyKey` before the `iconType`/`minWidth` arguments. Call sites that pass arguments positionally must be updated (or switched to named parameters) to account for this new parameter ordering. ([elastic#9413](elastic/eui#9413)) **Accessibility** - Fixed `aria-label` not being applied to `EuiColorPicker`'s input element ([elastic#9436](elastic/eui#9436)) ### @elastic/eui-theme-borealis v7.0.0 **Breaking changes** - Removed `severity.assistance` color token ([elastic#9507](elastic/eui#9507)) - Removed assistance datavis color tokens: ([elastic#9507](elastic/eui#9507)) - `vis.euiColorVisAssistance` - `vis.euiColorVis10` - `vis.euiColorVis11` - `vis.euiColorVisText10` - `vis.euiColorVisText11` - `vis.euiColorVisBehindText10` - `vis.euiColorVisBehindText11` ### @elastic/eslint-plugin-eui v2.11.0 - Updated `no-unnamed-interactive-element` to include checking `EuiColorPicker` ([elastic#9436](elastic/eui#9436)) --------- Co-authored-by: Timothy Sullivan <tsullivan@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Weronika Olejniczak <32842468+weronikaolejniczak@users.noreply.github.com> Co-authored-by: Weronika Olejniczak <weronika.olejniczak@elastic.co>

ppisljar added Feature:Timelion Timelion app and visualization review v5.2.0 v6.0.0 labels Dec 9, 2016

ppisljar requested review from rashidkpc and thomasneirynck December 9, 2016 16:03

ppisljar force-pushed the fix/timelion/axisMin branch 2 times, most recently from cf08a2a to 80d8aa0 Compare December 12, 2016 13:09

thomasneirynck self-assigned this Dec 13, 2016

tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Dec 16, 2016

fixing timelion yaxis min setting

9a3c8e8

ppisljar force-pushed the fix/timelion/axisMin branch from 80d8aa0 to 9a3c8e8 Compare December 19, 2016 13:12

kobelb self-requested a review December 21, 2016 09:33

kobelb reviewed Dec 21, 2016

View reviewed changes

rashidkpc approved these changes Dec 21, 2016

View reviewed changes

kobelb approved these changes Dec 21, 2016

View reviewed changes

ppisljar merged commit f9f63c4 into elastic:master Dec 21, 2016

elastic-jasper mentioned this pull request Dec 21, 2016

[5.x] fixing timelion yaxis min setting #9595

Merged

ppisljar added a commit that referenced this pull request Dec 21, 2016

fixing timelion yaxis min setting

14ad990

Backports PR #9428 **Commit 1:** fixing timelion yaxis min setting * Original sha: 9a3c8e8 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-09T15:58:29Z

ppisljar deleted the fix/timelion/axisMin branch December 21, 2016 19:39

ppisljar pushed a commit that referenced this pull request Dec 21, 2016

fixing timelion yaxis min setting (#9595)

15b7de3

Backports PR #9428 **Commit 1:** fixing timelion yaxis min setting * Original sha: 9a3c8e8 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-09T15:58:29Z

ppisljar restored the fix/timelion/axisMin branch September 26, 2018 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixing timelion yaxis min setting#9428

fixing timelion yaxis min setting#9428
ppisljar merged 1 commit intoelastic:masterfrom
ppisljar:fix/timelion/axisMin

ppisljar commented Dec 9, 2016

Uh oh!

ppisljar commented Dec 12, 2016

Uh oh!

thomasneirynck commented Dec 13, 2016 •

edited

Loading

Uh oh!

ppisljar commented Dec 14, 2016

Uh oh!

tbragin commented Dec 15, 2016 •

edited

Loading

Uh oh!

ppisljar commented Dec 19, 2016

Uh oh!

kobelb left a comment

Uh oh!

rashidkpc commented Dec 21, 2016

Uh oh!

kobelb left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ppisljar commented Dec 9, 2016

Uh oh!

ppisljar commented Dec 12, 2016

Uh oh!

thomasneirynck commented Dec 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ppisljar commented Dec 14, 2016

Uh oh!

tbragin commented Dec 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ppisljar commented Dec 19, 2016

Uh oh!

kobelb left a comment

Choose a reason for hiding this comment

Uh oh!

rashidkpc commented Dec 21, 2016

Uh oh!

kobelb left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thomasneirynck commented Dec 13, 2016 •

edited

Loading

tbragin commented Dec 15, 2016 •

edited

Loading