[Unified rules] Hide stack rules from global search by baileycash-elastic · Pull Request #260088 · elastic/kibana

baileycash-elastic · 2026-03-27T18:37:42Z

Summary

Closes https://github.com/elastic/kibana-team/issues/3108

Removes stack management rules from global search to avoid redundancy with unified rules

Before

Screen.Recording.2026-03-27.at.2.32.18.PM.mov

After

Screen.Recording.2026-03-27.at.2.33.52.PM.mov

elasticmachine · 2026-03-27T18:37:46Z

Pinging @elastic/response-ops (Team:ResponseOps)

macroscopeapp · 2026-03-27T18:41:31Z

Approvability

Verdict: Needs human review

This PR modifies visibility behavior for management items in global search by introducing a new visibleIn property that takes precedence over existing hideFromGlobalSearch logic. The author does not own any of the changed files, which are owned by @elastic/kibana-management and @elastic/response-ops teams who should review this behavioral change.

No code changes detected at c80d47c. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

src/platform/plugins/shared/management/public/plugin.tsx

baileycash-elastic · 2026-03-30T13:50:22Z

x-pack/platform/plugins/shared/triggers_actions_ui/public/plugin.ts

        id: PLUGIN_ID,
        title: featureTitle,
        order: 1,
+        visibleIn: [],


added visibleIn here to avoid changing the intentions behind hideFromGlobalSearch filter in management plugin. We still need the app in deep links to retain sidenav appearance

umbopepato

RO code changes LGTM!

mattkime · 2026-04-01T01:43:16Z

src/platform/plugins/shared/management/public/types.ts

  icon?: string; // URL to image file; fallback if no `euiIconType`
  hideFromSidebar?: boolean;
  hideFromGlobalSearch?: boolean; // Hide from global search results
+  visibleIn?: AppDeepLinkLocations[]; // Controls deep link visibility; takes precedence over hideFromGlobalSearch


Is there a reason t have both hideFromGlobalSearch and visibleIn? Could visibleIn be more descriptive, such as deepLinkVisibility?

hideFromGlobalSearch is being used in a couple of other places. This is a last minute change as part of the unified rules effort next week, trying to get approvals for its removal may delay us. I also didn't want to nuke a use case I'm not aware of.

visibleIn is a newer toggle used elsewhere in Kibana for deep link visibility management. I agree it's vague, but I didn't want to break away from convention in one place and have a discrepancy with how we manage visibility

I also didn't want to nuke a use case I'm not aware of.

I just wanted to verify my understanding, any cleanup could happen later.

visibleIn is a newer toggle used elsewhere in Kibana for deep link visibility management

Looks like its used in the core app interface, good reason to reuse it.

mattkime

Making sure this is an easy to understand addition to the api we expose. We should probably talk this over just to make sure I understand everything - while I understand how the management app works, I'm less clear about how things are exposed externally.

mattkime

🚀 🚀 🚀

elasticmachine · 2026-04-01T17:05:17Z

💔 Build Failed

Buildkite Build
Commit: c80d47c

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #201 / Agent Builder sidebar Sidebar Conversation Flow sends a message and receives a response

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`management`	12.4KB	12.5KB	+123.0B
`triggersActionsUi`	109.6KB	109.6KB	+13.0B
total			+136.0B

History

💚 Build #419943 succeeded 0cf4649
💔 Build #419279 failed 652a5cf
💔 Build #419123 failed 43a11cb
💚 Build #418351 succeeded a0dee87
💚 Build #418233 succeeded e1e1cf1

…heck * commit '6f040b29a5220ce12886a9731f656613e50aff06': (34 commits) [Entity Analytics] Add entity resolution UI to service flyout (elastic#260504) [Dashboard] Fix setState in embeddables (elastic#260082) [EDR Workflows] Unskip FTR tests that failed due to transient Fleet service unavailability (elastic#260519) [Observability:Streams] Fix query streams error handling test (elastic#260777) [Alerting v2] Dispatcher grouping modes, throttle strategies, and matcher autosuggestion (elastic#260249) [Dashboard] State extraction as a consistent override (elastic#259839) [Alerting v2] [Rule authoring] Fix rule name validation and error visibility in create/edit flow (elastic#260337) [Fix] re-introduce sln breadcrumbs to unified rules (elastic#260289) [Security Solution][Endpoint] Updated kibana docs to include `xpack.securitySolution.maxEndpointScriptFileSize` as configurable in cloud (elastic#260568) [Alerting v2] updated the alerting-v2-constants package with artifacts constants, fix to the runbook max characters (elastic#260342) [Automatic Import V2] Provide user tooltips (elastic#260725) [One Workflow] Deduplicate step types by base type in workflow list (elastic#260763) [Security Solution] Execution results UI: Enable the feature flag (elastic#260711) [Metrics][Discover] internal/search/esql_async returns 200 but METRICS_INFO responds with error (elastic#260746) Collapse redundant anyOf/oneOf array unions in OAS query params (elastic#260585) [Unified rules] Hide stack rules from global search (elastic#260088) [Agent Builder] Sidebar navigation updates (elastic#260728) [* As Code] Use PUT for upserts (elastic#260318) Update EUI to v114.0.0 (elastic#259497) [Entity Resolution] Add contextual-security-apps as co-owner of resolution paths (elastic#260659) ... # Conflicts: # src/platform/plugins/shared/dashboard/public/index.ts

## Summary Closes elastic/kibana-team#3108 Removes stack management rules from global search to avoid redundancy with unified rules ## Before https://github.com/user-attachments/assets/16f50bdc-1dfe-4922-9645-2af301facd67 ## After https://github.com/user-attachments/assets/5902d1aa-4107-4b51-b2cc-457254383dc6

[Unified rules] Hide stack rules from global search

70c4929

baileycash-elastic requested a review from a team as a code owner March 27, 2026 18:37

baileycash-elastic added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.4.0 labels Mar 27, 2026

github-actions bot added the author:actionable-obs PRs authored by the actionable obs team label Mar 27, 2026

baileycash-elastic requested a review from a team as a code owner March 27, 2026 20:59

macroscopeapp bot reviewed Mar 27, 2026

View reviewed changes

src/platform/plugins/shared/management/public/plugin.tsx Show resolved Hide resolved

fix deeplink test failure, add visibleIn to management item

e1e1cf1

baileycash-elastic force-pushed the kt-3108-hide-stack-rules-from-search branch from c14d467 to e1e1cf1 Compare March 27, 2026 21:22

Merge branch 'main' into kt-3108-hide-stack-rules-from-search

a0dee87

baileycash-elastic commented Mar 30, 2026

View reviewed changes

umbopepato approved these changes Mar 30, 2026

View reviewed changes

baileycash-elastic added 4 commits March 30, 2026 15:07

Merge branch 'main' into kt-3108-hide-stack-rules-from-search

43a11cb

Merge branch 'main' into kt-3108-hide-stack-rules-from-search

652a5cf

Merge branch 'main' into kt-3108-hide-stack-rules-from-search

444f235

Merge branch 'main' into kt-3108-hide-stack-rules-from-search

0cf4649

mattkime reviewed Apr 1, 2026

View reviewed changes

mattkime requested changes Apr 1, 2026

View reviewed changes

Merge branch 'main' into kt-3108-hide-stack-rules-from-search

c80d47c

mattkime approved these changes Apr 1, 2026

View reviewed changes

baileycash-elastic enabled auto-merge (squash) April 1, 2026 16:28

baileycash-elastic merged commit bb6117d into elastic:main Apr 1, 2026
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Unified rules] Hide stack rules from global search#260088

[Unified rules] Hide stack rules from global search#260088
baileycash-elastic merged 8 commits intoelastic:mainfrom
baileycash-elastic:kt-3108-hide-stack-rules-from-search

baileycash-elastic commented Mar 27, 2026 •

edited

Loading

Uh oh!

elasticmachine commented Mar 27, 2026

Uh oh!

macroscopeapp bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

baileycash-elastic Mar 30, 2026

Uh oh!

umbopepato left a comment

Uh oh!

mattkime Apr 1, 2026

Uh oh!

baileycash-elastic Apr 1, 2026 •

edited

Loading

Uh oh!

mattkime Apr 1, 2026 •

edited

Loading

Uh oh!

mattkime left a comment

Uh oh!

mattkime left a comment

Uh oh!

elasticmachine commented Apr 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

baileycash-elastic commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Before

After

Uh oh!

elasticmachine commented Mar 27, 2026

Uh oh!

macroscopeapp bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

baileycash-elastic Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

umbopepato left a comment

Choose a reason for hiding this comment

Uh oh!

mattkime Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

baileycash-elastic Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattkime Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Page load bundle

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

baileycash-elastic commented Mar 27, 2026 •

edited

Loading

macroscopeapp bot commented Mar 27, 2026 •

edited

Loading

baileycash-elastic Apr 1, 2026 •

edited

Loading

mattkime Apr 1, 2026 •

edited

Loading

elasticmachine commented Apr 1, 2026 •

edited

Loading