[* As Code] Use PUT for upserts by nreese · Pull Request #260318 · elastic/kibana

nreese · 2026-03-30T17:42:42Z

Closes #260047

Created #260606 as a follow on to consolidate meta schemas and helper functions into a package.

dashboard route changes:

Removes id URL parameter from POST route
Adds upsert to PUT route
Uses asCodeIdSchema for params.id in PUT route

markdown route changes:

Removes id URL parameter from POST route
Adds upsert to PUT route
Uses asCodeIdSchema for params.id in PUT route
Replaces markdown panel copy with markdown library item. Panel is a dashboard concept. Markdown as code CRUD API deals with library items - not panels

asCodeIdSchema changes:

removes maybe wrapper
removes derived type AsCodeId. Not used anywhere and just a string

nreese · 2026-03-30T17:42:53Z

/ci

nreese · 2026-03-30T18:13:16Z

/ci

nreese · 2026-03-30T18:20:52Z

/ci

nreese · 2026-03-30T18:57:21Z

/ci

nreese · 2026-03-30T19:21:48Z

/ci

…tion_tests/ci_checks

nreese · 2026-03-30T19:53:43Z

/ci

nreese · 2026-03-30T20:56:59Z

/ci

nreese · 2026-03-31T12:47:28Z

/ci

nreese · 2026-03-31T12:48:45Z

/ci

nreese · 2026-03-31T14:20:01Z

/ci

nreese · 2026-03-31T14:50:50Z

/ci

elasticmachine · 2026-03-31T16:31:05Z

Pinging @elastic/kibana-presentation (Team:Presentation)

src/platform/plugins/shared/dashboard/server/api/update/register_update_route.ts

src/platform/plugins/shared/dashboard_markdown/server/api/read/register_read_route.ts

src/platform/plugins/shared/dashboard/server/api/saved_object_utils.ts

elasticmachine · 2026-04-01T04:05:37Z

💚 Build Succeeded

Buildkite Build
Commit: e6051dc

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/as-code-shared-schemas`	2	1	-1

Unknown metric groups

API count

id	before	after	diff
`@kbn/as-code-shared-schemas`	2	1	-1

History

💔 Build #420169 failed e507940
💔 Build #420148 failed 1adf80b
💛 Build #419909 was flaky e8d6286
💛 Build #419786 was flaky a9892e5
💔 Build #419752 failed 907a8f4

nickpeihl

lgtm! presumably lens will update their apis in a separate PR?

nreese · 2026-04-01T17:10:53Z

presumably lens will update their apis in a separate PR?

Right. I am only fixing presentation owned APIs in this effort.

…heck * commit '6f040b29a5220ce12886a9731f656613e50aff06': (34 commits) [Entity Analytics] Add entity resolution UI to service flyout (elastic#260504) [Dashboard] Fix setState in embeddables (elastic#260082) [EDR Workflows] Unskip FTR tests that failed due to transient Fleet service unavailability (elastic#260519) [Observability:Streams] Fix query streams error handling test (elastic#260777) [Alerting v2] Dispatcher grouping modes, throttle strategies, and matcher autosuggestion (elastic#260249) [Dashboard] State extraction as a consistent override (elastic#259839) [Alerting v2] [Rule authoring] Fix rule name validation and error visibility in create/edit flow (elastic#260337) [Fix] re-introduce sln breadcrumbs to unified rules (elastic#260289) [Security Solution][Endpoint] Updated kibana docs to include `xpack.securitySolution.maxEndpointScriptFileSize` as configurable in cloud (elastic#260568) [Alerting v2] updated the alerting-v2-constants package with artifacts constants, fix to the runbook max characters (elastic#260342) [Automatic Import V2] Provide user tooltips (elastic#260725) [One Workflow] Deduplicate step types by base type in workflow list (elastic#260763) [Security Solution] Execution results UI: Enable the feature flag (elastic#260711) [Metrics][Discover] internal/search/esql_async returns 200 but METRICS_INFO responds with error (elastic#260746) Collapse redundant anyOf/oneOf array unions in OAS query params (elastic#260585) [Unified rules] Hide stack rules from global search (elastic#260088) [Agent Builder] Sidebar navigation updates (elastic#260728) [* As Code] Use PUT for upserts (elastic#260318) Update EUI to v114.0.0 (elastic#259497) [Entity Resolution] Add contextual-security-apps as co-owner of resolution paths (elastic#260659) ... # Conflicts: # src/platform/plugins/shared/dashboard/public/index.ts

Closes elastic#260047 Created elastic#260606 as a follow on to consolidate meta schemas and helper functions into a package. dashboard route changes: * Removes `id` URL parameter from POST route * Adds upsert to PUT route * Uses `asCodeIdSchema` for params.id in PUT route markdown route changes: * Removes `id` URL parameter from POST route * Adds upsert to PUT route * Uses `asCodeIdSchema` for params.id in PUT route * Replaces `markdown panel` copy with `markdown library item`. `Panel` is a dashboard concept. Markdown as code CRUD API deals with library items - not panels asCodeIdSchema changes: * removes `maybe` wrapper * removes derived type AsCodeId. Not used anywhere and just a string --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

nreese added 2 commits March 30, 2026 11:39

[* As Code] Use PUT for upserts

a8eefca

clean up

e5e507f

use as code for id in update route

73fb0ef

nreese force-pushed the issue_260047 branch from 3444334 to 73fb0ef Compare March 30, 2026 18:13

clean AsCodeId

db38e34

nreese added 2 commits March 30, 2026 12:34

fix imports

7dc9631

clean up copy

6ba3109

tslint

83b08d3

kibanamachine added 2 commits March 30, 2026 19:44

Changes from node scripts/jest_integration -u src/core/server/integra…

b706b71

…tion_tests/ci_checks

Changes from node scripts/eslint_all_files --no-cache --fix

d1cd5d6

update API tests

2fa04ef

Changes from node scripts/eslint_all_files --no-cache --fix

2345c51

Merge branch 'main' into issue_260047

847226e

fix tests

907a8f4

tslint

a9892e5

clean up test names

e8e4202

nreese marked this pull request as ready for review March 31, 2026 16:30

nreese requested review from a team as code owners March 31, 2026 16:30

nreese requested a review from a team as a code owner March 31, 2026 16:30

nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Project:Dashboards API v9.4.0 labels Mar 31, 2026

nickofthyme approved these changes Mar 31, 2026

View reviewed changes

Changes from node scripts/eslint_all_files --no-cache --fix

e8d6286

nickofthyme reviewed Mar 31, 2026

View reviewed changes

src/platform/plugins/shared/dashboard/server/api/update/register_update_route.ts Show resolved Hide resolved

return 201 on create

1adf80b

macroscopeapp bot reviewed Mar 31, 2026

View reviewed changes

src/platform/plugins/shared/dashboard_markdown/server/api/read/register_read_route.ts Show resolved Hide resolved

src/platform/plugins/shared/dashboard/server/api/saved_object_utils.ts Show resolved Hide resolved

nreese and others added 4 commits March 31, 2026 18:41

Merge branch 'main' into issue_260047

8b405bf

clean up

f4581f0

tslint

e507940

fix tests

e6051dc

jloleysens approved these changes Apr 1, 2026

View reviewed changes

nickpeihl self-requested a review April 1, 2026 13:54

nickpeihl approved these changes Apr 1, 2026

View reviewed changes

nreese merged commit f33f24c into elastic:main Apr 1, 2026
19 checks passed

Conversation

nreese commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented Mar 30, 2026

Uh oh!

nreese commented Mar 30, 2026

Uh oh!

nreese commented Mar 30, 2026

Uh oh!

nreese commented Mar 30, 2026

Uh oh!

nreese commented Mar 30, 2026

Uh oh!

nreese commented Mar 30, 2026

Uh oh!

nreese commented Mar 30, 2026

Uh oh!

nreese commented Mar 31, 2026

Uh oh!

nreese commented Mar 31, 2026

Uh oh!

nreese commented Mar 31, 2026

Uh oh!

nreese commented Mar 31, 2026

Uh oh!

elasticmachine commented Mar 31, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Apr 1, 2026

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

API count

History

Uh oh!

nickpeihl left a comment

Choose a reason for hiding this comment

Uh oh!

nreese commented Apr 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nreese commented Mar 30, 2026 •

edited

Loading