[Observability:Streams] Fix query streams error handling test#260777
Merged
couvq merged 1 commit intoelastic:mainfrom Apr 1, 2026
Merged
[Observability:Streams] Fix query streams error handling test#260777couvq merged 1 commit intoelastic:mainfrom
couvq merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/obs-onboarding-team (Team:obs-onboarding) |
Contributor
ApprovabilityVerdict: Needs human review This is a minimal test fix adding a wait for a code editor to be ready, with no production code impact. However, the author does not own this file (owned by obs-sig-events-team and obs-onboarding-team), so the designated owners should review this change. You can customize Macroscope's approvability policy. Learn more. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
mohamedhamed-ahmed
approved these changes
Apr 1, 2026
Contributor
mohamedhamed-ahmed
left a comment
There was a problem hiding this comment.
LGTM! Thank you
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Apr 1, 2026
…heck * commit '6f040b29a5220ce12886a9731f656613e50aff06': (34 commits) [Entity Analytics] Add entity resolution UI to service flyout (elastic#260504) [Dashboard] Fix setState in embeddables (elastic#260082) [EDR Workflows] Unskip FTR tests that failed due to transient Fleet service unavailability (elastic#260519) [Observability:Streams] Fix query streams error handling test (elastic#260777) [Alerting v2] Dispatcher grouping modes, throttle strategies, and matcher autosuggestion (elastic#260249) [Dashboard] State extraction as a consistent override (elastic#259839) [Alerting v2] [Rule authoring] Fix rule name validation and error visibility in create/edit flow (elastic#260337) [Fix] re-introduce sln breadcrumbs to unified rules (elastic#260289) [Security Solution][Endpoint] Updated kibana docs to include `xpack.securitySolution.maxEndpointScriptFileSize` as configurable in cloud (elastic#260568) [Alerting v2] updated the alerting-v2-constants package with artifacts constants, fix to the runbook max characters (elastic#260342) [Automatic Import V2] Provide user tooltips (elastic#260725) [One Workflow] Deduplicate step types by base type in workflow list (elastic#260763) [Security Solution] Execution results UI: Enable the feature flag (elastic#260711) [Metrics][Discover] internal/search/esql_async returns 200 but METRICS_INFO responds with error (elastic#260746) Collapse redundant anyOf/oneOf array unions in OAS query params (elastic#260585) [Unified rules] Hide stack rules from global search (elastic#260088) [Agent Builder] Sidebar navigation updates (elastic#260728) [* As Code] Use PUT for upserts (elastic#260318) Update EUI to v114.0.0 (elastic#259497) [Entity Resolution] Add contextual-security-apps as co-owner of resolution paths (elastic#260659) ... # Conflicts: # src/platform/plugins/shared/dashboard/public/index.ts
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
…c#260777) Closes elastic#258225 ## Summary The test for query stream error handling was not properly awaiting the monaco editor to be available, which led to some flaky test runs. This PR adds the necessary await to fix the test flakiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258225
Summary
The test for query stream error handling was not properly awaiting the monaco editor to be available, which led to some flaky test runs. This PR adds the necessary await to fix the test flakiness.