Skip to content

Fix broken test on meetings after merging PR without rebase#8076

Merged
leio10 merged 1 commit intodevelopfrom
fix/broken-meetings-test
May 28, 2021
Merged

Fix broken test on meetings after merging PR without rebase#8076
leio10 merged 1 commit intodevelopfrom
fix/broken-meetings-test

Conversation

@leio10
Copy link
Copy Markdown
Contributor

@leio10 leio10 commented May 28, 2021

🎩 What? Why?

After merging #7933 a broken test appeared because #7970 were merged before and the #7933 tests didn't run again with that changes. This PR fixes that.

📌 Related Issues

Link your PR to an issue

@leio10 leio10 requested a review from entantoencuanto May 28, 2021 14:07
@leio10 leio10 added module: meetings type: fix PRs that implement a fix for a bug in-review labels May 28, 2021
@leio10 leio10 merged commit 47484d5 into develop May 28, 2021
@leio10 leio10 deleted the fix/broken-meetings-test branch May 28, 2021 14:59
entantoencuanto added a commit that referenced this pull request May 28, 2021
…ions

* develop:
  Fix broken test on meetings after merging PR without rebase (#8076)
  Show participants list in meetings (#7933)
  Security feature external link warning (#7397)
entantoencuanto added a commit that referenced this pull request May 31, 2021
* develop: (59 commits)
  Update supported versions in docs (#8079)
  Meetings merge minutes and close actions (#7968)
  Meeting calendars providers (#7944)
  Fix broken test on meetings after merging PR without rebase (#8076)
  Show participants list in meetings (#7933)
  Security feature external link warning (#7397)
  Add missing tests for scope types admin page (#8053)
  Use symbols for polymorphic route arguments (#8052)
  Mockup design for Participation statistics tables in Votings (#7879)
  Fix boolean fields for .reported? and .hidden? which is nil if no report exists (#7990)
  Fix redirects broken by Terms and Conditions redirect (#8036)
  Amend CSS overwritting (#8007)
  New Crowdin updates (#8048)
  Fix undetected broken tests because of missing dependencies (#8050)
  Validate results by Monitoring Committee Members (#7899)
  Electoral certificate validation by Monitoring Committee Members (#7871)
  Publish and unpublish a meeting (#7893)
  New Crowdin updates (#8005)
  Polling station closure attach the physical electoral closure certificate (#7929)
  Fix attachment title migration generating possibly invalid values (#8020)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review module: meetings type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant