Fix redirects broken by Terms and Conditions redirect#8036
Merged
leio10 merged 2 commits intodecidim:developfrom May 25, 2021
Merged
Fix redirects broken by Terms and Conditions redirect#8036leio10 merged 2 commits intodecidim:developfrom
leio10 merged 2 commits intodecidim:developfrom
Conversation
2915bf3 to
08d93f7
Compare
leio10
previously approved these changes
May 25, 2021
Contributor
leio10
left a comment
There was a problem hiding this comment.
Great @alecslupu, I was very frustrated with this bug, thanks for taking care of it! ❤️
I added a small improvement suggestion, apply it if you think it will work properly and I will merge this in any case.
decidim-core/app/controllers/concerns/decidim/has_stored_path.rb
Outdated
Show resolved
Hide resolved
e305214 to
9d650a3
Compare
entantoencuanto
added a commit
that referenced
this pull request
May 31, 2021
* develop: (59 commits) Update supported versions in docs (#8079) Meetings merge minutes and close actions (#7968) Meeting calendars providers (#7944) Fix broken test on meetings after merging PR without rebase (#8076) Show participants list in meetings (#7933) Security feature external link warning (#7397) Add missing tests for scope types admin page (#8053) Use symbols for polymorphic route arguments (#8052) Mockup design for Participation statistics tables in Votings (#7879) Fix boolean fields for .reported? and .hidden? which is nil if no report exists (#7990) Fix redirects broken by Terms and Conditions redirect (#8036) Amend CSS overwritting (#8007) New Crowdin updates (#8048) Fix undetected broken tests because of missing dependencies (#8050) Validate results by Monitoring Committee Members (#7899) Electoral certificate validation by Monitoring Committee Members (#7871) Publish and unpublish a meeting (#7893) New Crowdin updates (#8005) Polling station closure attach the physical electoral closure certificate (#7929) Fix attachment title migration generating possibly invalid values (#8020) ...
leio10
pushed a commit
that referenced
this pull request
May 31, 2021
* Fix redirects broken by Terms and Conditions redirect * Fix redirects broken by Terms and Conditions redirect - improvements
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Move store_current_location before the needs_tos_accepted, in order ensure the requested path is being persisted before tos intercepting the request. In that way, after the user accepts the tos, it will be redirected to previously requested page.
📌 Related Issues
Link your PR to an issue
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
