Skip to content

Polling station closure attach the physical electoral closure certificate#7929

Merged
leio10 merged 2 commits intodevelopfrom
feat/polling_station_closure_attach_certificate
May 24, 2021
Merged

Polling station closure attach the physical electoral closure certificate#7929
leio10 merged 2 commits intodevelopfrom
feat/polling_station_closure_attach_certificate

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Apr 30, 2021

🎩 What? Why?

This PR adds the ability to the polling officer to attach an image(s) of the physical closure to the polling station closure.

📌 Related Issues

Testing

  • Go to the polling officer zone, fill in all the ballot/vote recount.
  • in the next step you can attach the closure images.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

  • Screenshot 2021-04-30 at 18-20-41 MacGyver-Leffler
  • Screenshot 2021-04-30 at 18-21-20 MacGyver-Leffler

♥️ Thank you!

@agustibr agustibr self-assigned this Apr 30, 2021
@agustibr agustibr added project: e-voting Barcelona City Council contract module: elections labels Apr 30, 2021
orlera
orlera previously approved these changes May 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📸

@agustibr agustibr force-pushed the feat/polling_station_closure_attach_certificate branch from af873ad to ddae786 Compare May 10, 2021 09:22
@leio10 leio10 force-pushed the feat/polling_station_sign_closure branch from f02f87f to d36f1d4 Compare May 17, 2021 17:07
@leio10 leio10 force-pushed the feat/polling_station_closure_attach_certificate branch from ddae786 to 7f73672 Compare May 17, 2021 17:10
@leio10 leio10 force-pushed the feat/polling_station_sign_closure branch from d36f1d4 to 252e431 Compare May 24, 2021 10:16
Base automatically changed from feat/polling_station_sign_closure to develop May 24, 2021 11:05
@leio10 leio10 force-pushed the feat/polling_station_closure_attach_certificate branch from 7f73672 to 0b1c75f Compare May 24, 2021 11:07
@leio10 leio10 merged commit a8bedd9 into develop May 24, 2021
@leio10 leio10 deleted the feat/polling_station_closure_attach_certificate branch May 24, 2021 13:27
entantoencuanto added a commit that referenced this pull request May 31, 2021
@entantoencuanto
Merge branch 'develop' into active_storage_migration
cad4728 
* develop: (59 commits)
  Update supported versions in docs (#8079)
  Meetings merge minutes and close actions (#7968)
  Meeting calendars providers (#7944)
  Fix broken test on meetings after merging PR without rebase (#8076)
  Show participants list in meetings (#7933)
  Security feature external link warning (#7397)
  Add missing tests for scope types admin page (#8053)
  Use symbols for polymorphic route arguments (#8052)
  Mockup design for Participation statistics tables in Votings (#7879)
  Fix boolean fields for .reported? and .hidden? which is nil if no report exists (#7990)
  Fix redirects broken by Terms and Conditions redirect (#8036)
  Amend CSS overwritting (#8007)
  New Crowdin updates (#8048)
  Fix undetected broken tests because of missing dependencies (#8050)
  Validate results by Monitoring Committee Members (#7899)
  Electoral certificate validation by Monitoring Committee Members (#7871)
  Publish and unpublish a meeting (#7893)
  New Crowdin updates (#8005)
  Polling station closure attach the physical electoral closure certificate (#7929)
  Fix attachment title migration generating possibly invalid values (#8020)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leio10 leio10 Awaiting requested review from leio10

@slickepinne slickepinne Awaiting requested review from slickepinne

@beagleknight beagleknight Awaiting requested review from beagleknight

1 more reviewer

@orlera orlera orlera left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@agustibr agustibr

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Capture a picture of the physical electoral closure certificate

3 participants

@agustibr @orlera @leio10