Skip to content

Show participants list in meetings#7933

Merged
leio10 merged 5 commits intodevelopfrom
7297-show_participants_list_in_meetings
May 28, 2021
Merged

Show participants list in meetings#7933
leio10 merged 5 commits intodevelopfrom
7297-show_participants_list_in_meetings

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented May 4, 2021 •
edited
Loading

🎩 What? Why?

This PR:

  • Adds a public_participation column to meetings registrations table, false by default
  • Adds a checkbox on registrations form to set public participation both if the registration process has a questionnaire or not
  • Displays a list of attending participants in meeting page when there is at least a user which has set their participation as public. This option is ignored when the user participates represented by a group. In this case the participation is always shown as organization in the attending organizations list as usual.
  • Adds some tests in join meetings command and meeting registrations system specs

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@entantoencuanto entantoencuanto force-pushed the 7297-show_participants_list_in_meetings branch from 53297bf to dc333d1 Compare May 4, 2021 21:18
@entantoencuanto entantoencuanto marked this pull request as ready for review May 4, 2021 21:53
@entantoencuanto entantoencuanto force-pushed the 7297-show_participants_list_in_meetings branch from dc333d1 to d5981a7 Compare May 4, 2021 22:13
@github-actions github-actions bot mentioned this pull request May 5, 2021
Closed
@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented May 5, 2021

@entantoencuanto watch out, conflicts!

@entantoencuanto
Add migration to include a public_participation column in meetings re…
cff32c8 
…gistrations table
@entantoencuanto
Add public_participation checkbox in meetings registration forms
37a4b48 
This checkbox also has to be added to a questionnaire form if defined
for a meeting, but skipped in other cases.
@entantoencuanto
Add tests to join_meeting command for public participation
c9219e1
@entantoencuanto
Display public participants of a meetings in show
88a0ac0 
The public participants list only show people, if they are represented
as an organization they appear in the attending organizations list as usual
@entantoencuanto
Add system tests for public attending participants
c5a5b18
@entantoencuanto entantoencuanto force-pushed the 7297-show_participants_list_in_meetings branch from d5981a7 to c5a5b18 Compare May 10, 2021 08:47
leio10
leio10 approved these changes May 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! I think we should find a better approach for adding fixed checkboxes to questionnaires for meetings, but it was already there for the "represents user group" checkbox, so I think we can leave that for later. 👍

@leio10 leio10 merged commit 3319002 into develop May 28, 2021
@leio10 leio10 deleted the 7297-show_participants_list_in_meetings branch May 28, 2021 09:54
This was referenced May 28, 2021
Merged
Merged
entantoencuanto added a commit that referenced this pull request May 28, 2021
@entantoencuanto
Merge branch 'develop' into 7285-meetings-merge-minutes-and-close-act…
c419ea8 
…ions

* develop:
  Fix broken test on meetings after merging PR without rebase (#8076)
  Show participants list in meetings (#7933)
  Security feature external link warning (#7397)
entantoencuanto added a commit that referenced this pull request May 31, 2021
@entantoencuanto
Merge branch 'develop' into active_storage_migration
cad4728 
* develop: (59 commits)
  Update supported versions in docs (#8079)
  Meetings merge minutes and close actions (#7968)
  Meeting calendars providers (#7944)
  Fix broken test on meetings after merging PR without rebase (#8076)
  Show participants list in meetings (#7933)
  Security feature external link warning (#7397)
  Add missing tests for scope types admin page (#8053)
  Use symbols for polymorphic route arguments (#8052)
  Mockup design for Participation statistics tables in Votings (#7879)
  Fix boolean fields for .reported? and .hidden? which is nil if no report exists (#7990)
  Fix redirects broken by Terms and Conditions redirect (#8036)
  Amend CSS overwritting (#8007)
  New Crowdin updates (#8048)
  Fix undetected broken tests because of missing dependencies (#8050)
  Validate results by Monitoring Committee Members (#7899)
  Electoral certificate validation by Monitoring Committee Members (#7871)
  Publish and unpublish a meeting (#7893)
  New Crowdin updates (#8005)
  Polling station closure attach the physical electoral closure certificate (#7929)
  Fix attachment title migration generating possibly invalid values (#8020)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@leio10 leio10 leio10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

in-review module: meetings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show participants list in meetings

3 participants

@entantoencuanto @mrcasals @leio10