Merged
Conversation
85b1ec9 to
c2d018b
Compare
mrcasals
reviewed
May 4, 2021
Contributor
mrcasals
left a comment
There was a problem hiding this comment.
As I said in the issue, I'd add a way to tell the admins that meetings need to be published manually now. At least, modify the flash message on meeting creation to tell that?
Contributor
|
Apart from that, code looks good! |
8 tasks
mrcasals
previously approved these changes
May 10, 2021
Contributor
|
@ferblape ping me when it's ready to be merged! I see the issue is at the "QA Testing" step... |
db2ef41 to
7332c3e
Compare
Contributor
Author
|
@mrcasals we got the acceptance of product, so this could be reviewed again and merged 😄 |
leio10
suggested changes
May 24, 2021
decidim-meetings/db/migrate/20210413050917_update_published_at_to_existing_meetings.rb
Outdated
Show resolved
Hide resolved
leio10
approved these changes
May 24, 2021
leio10
added a commit
that referenced
this pull request
May 24, 2021
leio10
added a commit
that referenced
this pull request
May 24, 2021
leio10
added a commit
that referenced
this pull request
May 24, 2021
* chore: add dev dependency of meetings in participatory_processes * fix: repair tests broken by #7893
entantoencuanto
added a commit
that referenced
this pull request
May 31, 2021
* develop: (59 commits) Update supported versions in docs (#8079) Meetings merge minutes and close actions (#7968) Meeting calendars providers (#7944) Fix broken test on meetings after merging PR without rebase (#8076) Show participants list in meetings (#7933) Security feature external link warning (#7397) Add missing tests for scope types admin page (#8053) Use symbols for polymorphic route arguments (#8052) Mockup design for Participation statistics tables in Votings (#7879) Fix boolean fields for .reported? and .hidden? which is nil if no report exists (#7990) Fix redirects broken by Terms and Conditions redirect (#8036) Amend CSS overwritting (#8007) New Crowdin updates (#8048) Fix undetected broken tests because of missing dependencies (#8050) Validate results by Monitoring Committee Members (#7899) Electoral certificate validation by Monitoring Committee Members (#7871) Publish and unpublish a meeting (#7893) New Crowdin updates (#8005) Polling station closure attach the physical electoral closure certificate (#7929) Fix attachment title migration generating possibly invalid values (#8020) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR changes the default behaviour of meetings created by admins. The new default is that meetings are now unpublished by default (meetings are now
Publicable), and a new action has been added to admins meeting management to allow to publish it as described in the issue.Meetings scopes have also been updated to prevent unpublished meetings to be shown in the API or the search results.
With respect to meetings created by users, the behaviour hasn't changed and they are created as published by default (see clarification comment)
📌 Related Issues
Testing
As an admin
As an user
Unpublished meetings
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Meetings list have a new action to publish/unpublish: