Conversation
ahukkanen
reviewed
May 14, 2021
decidim-core/app/packs/stylesheets/decidim/decidim_application.scss
Outdated
Show resolved
Hide resolved
ahukkanen
reviewed
May 14, 2021
| # Copy CSS variables template file | ||
| # Copy CSS files | ||
| copy_file "decidim_application.scss", "app/packs/stylesheets/decidim/decidim_application.scss" | ||
| copy_file "_decidim-settings.scss", "app/packs/stylesheets/decidim/_decidim-settings.scss" |
Contributor
There was a problem hiding this comment.
I'm wondering if we should copy this file to the application by default.
I would be personally fine with that (since it's needed in all cases for us) but the current core does not automatically copy this file, which is why I wonder if it should be done.
Contributor
Author
There was a problem hiding this comment.
Right, I was copying it for simplicity for developers to start overriding vars (I think most of the Rails apps use this feature to change colors). What do you think @mrcasals ?
entantoencuanto
added a commit
that referenced
this pull request
May 31, 2021
* develop: (59 commits) Update supported versions in docs (#8079) Meetings merge minutes and close actions (#7968) Meeting calendars providers (#7944) Fix broken test on meetings after merging PR without rebase (#8076) Show participants list in meetings (#7933) Security feature external link warning (#7397) Add missing tests for scope types admin page (#8053) Use symbols for polymorphic route arguments (#8052) Mockup design for Participation statistics tables in Votings (#7879) Fix boolean fields for .reported? and .hidden? which is nil if no report exists (#7990) Fix redirects broken by Terms and Conditions redirect (#8036) Amend CSS overwritting (#8007) New Crowdin updates (#8048) Fix undetected broken tests because of missing dependencies (#8050) Validate results by Monitoring Committee Members (#7899) Electoral certificate validation by Monitoring Committee Members (#7871) Publish and unpublish a meeting (#7893) New Crowdin updates (#8005) Polling station closure attach the physical electoral closure certificate (#7929) Fix attachment title migration generating possibly invalid values (#8020) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR improves how CSS are overwritten:
📌 Related Issues
Testing
Create a new development_app with no CSS overrides.
Three scenarios:
You should see the body has changed in the whole app
You should paragraphs in red
cp decidim-core/app/packs/stylesheets/decidim/layouts/_home.scss development_app/app/packs/stylesheets/decidim/layouts/. Then edit the overriden file and change some styles, you should see those styles in the app📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
